Fix list of supported Python versions in Trove classifiers. #4
Conversation
Let TravisCI test the same versions as tox.ini.
MANIFEST.in
Outdated
| include .coveragerc | ||
|
|
||
| recursive-include src * | ||
| include buildout.cfg | ||
| exclude buildout.cfg |
There was a problem hiding this comment.
I did this not without a reason: When only using exclude I get a log message at install time that buildout.cfg cannot be excluded because it does not exist. If it is included beforehand, the log message is omitted.
If I completely omit it form MANIFEST.in then check-manifest complains because it is under version control.
If I configure check-manifest to not complain (via setup.cfg) buildout.cfg does not get excluded from the sdist.
So include + exclude looks ugly but is the only solution I found to omit buildout.cfg (or any other file under version control) from the sdist resp. wheel without any complaints.
I am open to a better or easier solution.
There was a problem hiding this comment.
Ah! Okay, can you add a brief comment explaining this? Something like
# using include + exclude here to exclude buildout.cfg when building an sdist
# without producing "does not exist" warnings when installing from an sdist.
There was a problem hiding this comment.
(Personally, I would just include buildout.cfg in the dists -- less hassle, no harm.)
There was a problem hiding this comment.
Okay, you are right this is way easier.
MANIFEST.in
Outdated
| exclude buildout.cfg | ||
|
|
||
| include .travis.yml | ||
| exclude .travis.yml |
There was a problem hiding this comment.
Given that all the Python versions I wanted were already mentioned in the changelog, I retract my request for changes.
(I would love some changes though, the let's both include and exclude the same file in MANIFEST.in seems very strange, and I have doubts about the number of backticks change in that docstring.)
See zopefoundation/meta#1.
And flake8 the code.