-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build errors on recent macOS versions. #150
Conversation
I have no idea about the failures when pushing to coveralls. |
I also saw the coveralls errors in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python 3.8+ has reused the slot used for tp_print
in Python 2 (and therefore had as type a function pointer) as tp_vectorcall_offset
(now a size
slot).
I suggest to not only use a type correct initializer for the slot but also change the explanatory comment.
Co-authored-by: Dieter Maurer <[email protected]>
@d-maurer Thank you for your suggestions, could you please re-review? |
Co-authored-by: Dieter Maurer <[email protected]>
Traceback without these changes
I am running on Sonoma 14.4.1 on an Apple chip.
The
PyExtensionClass
is actually aPyTypeObject
and the examples in the Python docs also use a0
here instead ofNULL
: https://docs.python.org/3/c-api/typeobj.html#typedef-examples