fix(classifier): advance subjects immediately on Done

[eatyourgreens]

Pass a doneAndTalk flag to completeClassification when Done or Done & Talk is clicked. Advance the subject queue immediately if it's false, otherwise wait until the classification is saved before advancing the subject and going to Talk.

Please request review from @zooniverse/frontend team or an individual member of that team.

Package

• lib-classifier

Linked Issue and/or Talk Post

• fixes Classifier: Long delays (up to 10s) after pressing Done #6698.
• partially reverts the changes from Defer Done & Talk until classification has saved #4767, going back to the original classifier behaviour for Done but retaining the current behaviour for Done & Talk.
• this old explanation of mine, explaining how the subject queue advances, was useful too: Repeat subjects on workflows with sequential classification #3016 (comment)
• Daily Minor Planet Talk discussion about the classifier hanging after pressing Done: https://www.zooniverse.org/projects/fulsdavid/the-daily-minor-planet/talk/5639/3570312

How to Review

You can test this out by classifying on Daily Minor Planet:
https://localhost:8080/?project=fulsdavid/the-daily-minor-planet&env=production

After pressing Done, the next subject will load while your classification saves in the background (like PFE.)

After pressing Done & Talk, your classification is saved before the page unloads and goes to Talk.

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

• Tests are passing locally and on Github
• Documentation is up to date and changelog has been updated if appropriate
• You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
• FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)
• FEM works in a mobile browser

General UX

Example Staging Project: i-fancy-cats

• All pages of a FEM project load: Home Page, Classify Page, and About Pages
• Can submit a classification
• Can sign-in and sign-out
• The component is accessible
  • Can be used with a screen reader BBC guide to VoiceOver
  • Can be used from the keyboard WebAIM guide to keyboard testing
  • It is passing accessibility checks in the storybook

Bug Fix

• The PR creator has listed user actions to use when testing if bug is fixed
• The bug is fixed
• Unit tests are added or updated

[coveralls]

coverage: 75.548% (+0.004%) from 75.544%
when pulling ec08934 on eatyourgreens:subject-advance
into 415dc1c on zooniverse:master.

[eatyourgreens]

This patch works because the classifier's root store advances the subject queue when the classification loading state changes to 'posting' (which isn't immediately obvious, to be honest.)

front-end-monorepo/packages/lib-classifier/src/store/RootStore.js

Lines 72 to 78 in 9c6bfa8

	function _onPatch(patch) {
	// TODO: why are we doing this rather than observe classifications.loadingState for changes?
	const { path, value } = patch
	if (path === '/classifications/loadingState' && value === 'posting') {
	self.subjects.advance()
	}
	}