Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist video volume + playback speed between classifications #6668

Open
wants to merge 7 commits into
base: video-subject-viewer-enhancements
Choose a base branch
from

Conversation

goplayoutside3
Copy link
Contributor

@goplayoutside3 goplayoutside3 commented Feb 5, 2025

Package

lib-classifier

Linked Issue and/or Talk Post

Builds on top of #6655
Closes: #6334

Describe your changes

  • Store volume and setVolume in MST subject viewer store so its value persists between subjects during classification
  • Store videoSpeed and setVideoSpeed in MST subject viewer store

This feature applies only to workflows with drawing tools enabled (for now). It's intentional because the final step of my work on custom video controls will be to enable them on all video subjects, but for now I don't want to affect live projects.

How to Review

All design-related and accessibility-related changes are in #6655. This PR edits MST to enable persistent control preferences.

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)
  • FEM works in a mobile browser

General UX

Example Staging Project: i-fancy-cats

  • All pages of a FEM project load: Home Page, Classify Page, and About Pages
  • Can submit a classification
  • Can sign-in and sign-out
  • The component is accessible

New Feature

  • The PR creator has listed user actions to use when testing the new feature
  • Unit tests are included for the new feature
  • A storybook story has been created or updated
    • Example of SlideTutorial component with docgen comments, and its story

@goplayoutside3 goplayoutside3 added enhancement New feature or request video subject Issue related to the video subject viewer labels Feb 5, 2025
@goplayoutside3 goplayoutside3 changed the title Persist video subject volume between classifications Persist video volume + playback speed between classifications Feb 5, 2025
@goplayoutside3 goplayoutside3 marked this pull request as ready for review February 6, 2025 22:24
@goplayoutside3 goplayoutside3 requested a review from a team February 6, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request video subject Issue related to the video subject viewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant