Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump grommet from 2.41.0 to 2.45.1 #6667

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 5, 2025

Bumps grommet from 2.41.0 to 2.45.1.

Release notes

Sourced from grommet's releases.

v2.45.1

  • Bumped grommet-icons dependency to v4.12.4 to resolve a bug introduced in v4.12.2. grommet/grommet#7502

v2.45.0

General:

  • Added theme.toggleGroup.container.extend to allow passing custom styles to the ToggleGroup container. (grommet/grommet#7487)
  • Added theme.dataTable.body.row.extend to enable passing custom styles to DataTable rows. (grommet/grommet#7489)
  • Added ability for a compound focus indicator approach. Opt in to this approach with theme.global.focus.twoColor. (grommet/grommet#7479)
  • Added theme.select.listbox.extend and theme.selectMultiple.listbox.extend to allow styling of the listbox container around the options in Select and SelectMultiple. (grommet/grommet#7496)
  • Added theme.notification.message.fill to allow opt-in of the notification message filling the container instead of having a max-width when direction: column. (grommet/grommet#7488)
  • Added theme.anchor.size[size].gap to enable defining a gap for anchor based on the anchor size. (grommet/grommet#7491)
  • Added theme.menu.container to enable passing any Box props to the container around the Menu options. (grommet/grommet#7494)
  • Added theme.global.radius and theme.global.breakpoint[size].radius to allow for radius values to be styled independently from edgeSize. (grommet/grommet#7499)
  • Fixed an issue with Select hover styles still being applied after mouseOut event. (grommet/grommet#7469)

FormField:

  • Added theme.formField.disabled.help.color and theme.formField.disabled.info.color to the theme to allow styling the text color of the help and info sections in FormField. (grommet/grommet#7484)
  • Added theme.formField[inputName].container.extend to allow passing custom styles to the formField container based on the input type. (grommet/grommet#7498)
  • Added theme.formField.focus.containerFocus to enable an opt-in where in some cases based on if it makes sense for the input type the focus is managed by the child component instead of the FormField. (grommet/grommet#7490)

v2.44.0

General:

  • Fixed console log warning with Layer. (#7460)
  • Fixed StarRating to include a focus indicator when navigating with keyboard. (#7466)
  • Fixed ThumbsRating to include a focus indicator when navigating with keyboard. (#7466)
  • Fixed Notification status colors to meet WCAG contrast requirements. (#7472)
  • Fixed FormField error text color to meet WCAG contrast requirements. (#7472)

Calendar:

  • Added level prop to control the size of Heading. (#7456)
  • Added calendar.day.adjacent.color to theme to enable changing the color of the text for days displayed that are outside of the current month whenshowAdjacentDays is true. (#7473)
  • Fixed colors to meet WCAG contrast requirements. (#7473)

v2.43.0

General:

  • Added messages on Meter. (#7445)
  • Added an announcement for max character count in FormField. (#7446)
  • Fixed issue in typescript environments with Accordion useId. (#7444)
  • Fixed incorrect aria role usage on Calendar. (#7437)
  • Fixed TextInput text alignment with long options. (#7419)

List:

  • Fixed accessibility violations with onOrder on List. (#7433)
  • Fixed keyboard behavior so the active item is always in view. (#7448)

v2.42.0

General:

  • Added cssGap to propTypes and typescript for Box.(#7383)
  • Enhanced Notification theme for status/kind message and title colors.(#7411)

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 5, 2025
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/grommet-2.45.1 branch from 7bb6fe2 to ba4a63c Compare February 5, 2025 22:27
Bumps [grommet](https://github.com/grommet/grommet) from 2.41.0 to 2.45.1.
- [Release notes](https://github.com/grommet/grommet/releases)
- [Commits](grommet/grommet@v2.41.0...v2.45.1)

---
updated-dependencies:
- dependency-name: grommet
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/grommet-2.45.1 branch from ba4a63c to c96c25a Compare February 5, 2025 22:37
@shaunanoordin
Copy link
Member

Alright, I see that in packages/app-project/src/shared/components/CollectionsModal/components/SelectCollection/SelectCollection.js , there's this code...

function collectionLabel(collection) {
  if (collection.links.owner.id === userID) {
    return collection.display_name
  }
  return `${collection.display_name} (${collection.links.owner.display_name})`
}

The code here can be brittle because e.g. collection.links can be undefined. I can fix this by adding ?. existential operators in the code, causing collectionLabel() to return undefined on an error. (Which seems fair enough for this function.)

However, the real question I have is... what's in Grommet 2.45.1 that's causing this error to trigger?

(PS the tests have been re-run a few times to ensure it's a consistent error.)

(Slack: copy-pasted from https://zooniverse.slack.com/archives/CANKLB50E/p1738797294059089)

@shaunanoordin
Copy link
Member

Code patch #6669 needs to be merged before this can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant