Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retry constraints and wait_for_success as true for training jobs #51

Merged
merged 2 commits into from
Sep 11, 2024
Merged

add retry constraints and wait_for_success as true for training jobs #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01c5b05
add retry constraints and wait_for_success as true for training jobs
Tooyosi Sep 11, 2024
a2ec5fa
add retry constraints to prediction job
Tooyosi Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bajor/batch/predictions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ def create_batch_job(job_id, manifest_url, pool_id):
copy_code_to_shared_dir = 'cp -Rf $AZ_BATCH_NODE_MOUNTS_DIR/$PREDICTIONS_CONTAINER_MOUNT_DIR/$CODE_DIR_PATH/* $AZ_BATCH_NODE_SHARED_DIR/'
job.job_preparation_task = batchmodels.JobPreparationTask(
command_line=f'/bin/bash -c \"set -ex; {create_results_dir}; {copy_code_to_shared_dir}\"',
constraints=batchmodels.TaskConstraints(max_task_retry_count=3),
#
# A busted preparation task means the main task won't launch...ever!
# and leave the node in a scaled state costing $$ ££
Expand Down
3 changes: 2 additions & 1 deletion bajor/batch/train_finetuning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ def create_batch_job(job_id, manifest_container_path, pool_id):
setup_pytorch_kernel_cache_dir = 'mkdir -p $AZ_BATCH_NODE_SHARED_DIR/.cache/torch/kernels'
job.job_preparation_task = batchmodels.JobPreparationTask(
command_line=f'/bin/bash -c \"set -ex; {setup_pytorch_kernel_cache_dir}; {create_results_dir}; {copy_code_to_shared_dir}\"',
constraints=batchmodels.TaskConstraints(max_task_retry_count=3),
#
# A busted preparation task means the main task won't launch...ever!
# and leave the node in a scaled state costing $$ ££
Expand All @@ -123,7 +124,7 @@ def create_batch_job(job_id, manifest_container_path, pool_id):
# Short term: avoid waiting for this prep task to complete before starting the main task
# https://learn.microsoft.com/en-us/python/api/azure-batch/azure.batch.models.JobPreparationTask?view=azure-python#constructor
# https://learn.microsoft.com/en-us/azure/batch/batch-job-task-error-checking#job-preparation-tasks
wait_for_success=False)
wait_for_success=True)


# Job release task that runs after the job completes
Expand Down
3 changes: 2 additions & 1 deletion bajor/batch/train_from_scratch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ def create_batch_job(job_id, manifest_container_path, pool_id):
copy_code_to_shared_dir = 'cp -Rf $AZ_BATCH_NODE_MOUNTS_DIR/$TRAINING_CONTAINER_MOUNT_DIR/$CODE_DIR_PATH/* $AZ_BATCH_NODE_SHARED_DIR/'
job.job_preparation_task = batchmodels.JobPreparationTask(
command_line=f'/bin/bash -c \"set -ex; {create_results_dir}; {copy_code_to_shared_dir}\"',
constraints=batchmodels.TaskConstraints(max_task_retry_count=3),
#
# A busted preparation task means the main task won't launch...ever!
# and leave the node in a scaled state costing $$ ££
Expand All @@ -115,7 +116,7 @@ def create_batch_job(job_id, manifest_container_path, pool_id):
# Short term: avoid waiting for this prep task to complete before starting the main task
# https://learn.microsoft.com/en-us/python/api/azure-batch/azure.batch.models.JobPreparationTask?view=azure-python#constructor
# https://learn.microsoft.com/en-us/azure/batch/batch-job-task-error-checking#job-preparation-tasks
wait_for_success=False)
wait_for_success=True)


# Job release task that runs after the job completes
Expand Down
Loading