refactor: Restructure repo #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
requested changes
Feb 18, 2024
|
@viceice any chances you could look into necessary workflow changes so we could finish this PR? |
viceice
reviewed
Mar 2, 2024
|
will look at required workflow changes the next days. |
viceice
reviewed
Mar 3, 2024
|
This PR seems stalled. Should I close it? |
Why? you need to re-request review when you've done all required changes Please also fix the conflicts |
|
It seems all previous issues are addressed and fixed. Except for any potentially required workflow changes - which you wrote you will tackle. |
viceice
requested changes
May 5, 2024
viceice
reviewed
May 5, 2024
|
ok, will fix your PR tomorrow |
|
@gintsk why closed? |
viceice
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #96
MimeMappingproject tosrc/MimeMappingTesttoMimeMapping.Testsand move test project totest/MimeMapping.Testsuse global.json with .NET SDK version 8.0.100 (8.0.200 not yet available for builds)will do it in a separate PR@viceice please check
.github/workflowsas changes may be required due to use ofartifactsoutput.