Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong application/mp4 mime type from extension #164

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Tornhoof
Copy link

application/mp4 is put onto an ignore list.
closes #160

Copy link
Owner

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be made to the data source at https://github.com/jshttp/mime-db#mime-db right?

@Tornhoof
Copy link
Author

Tornhoof commented Jan 16, 2025

I don't think so, the JS lib (as far as I can see in the Readme) does mimetype -> file extension.
The problem here is file extension -> mime type

Copy link
Collaborator

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please split our the formating changes to a seperate pr

@viceice viceice changed the title Try to fix the bad application/mp4 mime types fix: wrong application/mp4 mime type from extension Jan 17, 2025
@Tornhoof
Copy link
Author

done, the whole Witespace fixes were an attempt to reduce the WS diffs in github, so i recommend reviewing it without whitespace

@viceice
Copy link
Collaborator

viceice commented Jan 17, 2025

done, the whole Witespace fixes were an attempt to reduce the WS diffs in github, so i recommend reviewing it without whitespace

can we do the whitespace change first in a separate pr, so future pr's benefit from less whitespace changes?

@Tornhoof
Copy link
Author

The problem with T4 templates is, that the generation is heavily dependent on your VS configuration, just like in the good old days. All my attempts to recreate a setup without whitespace changes failed, it might be possible with things like .editorconfig files, but I have never used them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MP4 Mime type changed
3 participants