-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrong application/mp4
mime type from extension
#164
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change should be made to the data source at https://github.com/jshttp/mime-db#mime-db right?
I don't think so, the JS lib (as far as I can see in the Readme) does mimetype -> file extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please split our the formating changes to a seperate pr
application/mp4
mime type from extension
done, the whole Witespace fixes were an attempt to reduce the WS diffs in github, so i recommend reviewing it without whitespace |
can we do the whitespace change first in a separate pr, so future pr's benefit from less whitespace changes? |
The problem with T4 templates is, that the generation is heavily dependent on your VS configuration, just like in the good old days. All my attempts to recreate a setup without whitespace changes failed, it might be possible with things like .editorconfig files, but I have never used them. |
application/mp4 is put onto an ignore list.
closes #160