refactor(shields): Move to upstream voltage-divider driver#3269
Open
VeyPatch wants to merge 2 commits intozmkfirmware:mainfrom
Open
refactor(shields): Move to upstream voltage-divider driver#3269VeyPatch wants to merge 2 commits intozmkfirmware:mainfrom
VeyPatch wants to merge 2 commits intozmkfirmware:mainfrom
Conversation
- Change compatible to "voltage-divider" - Add ADC configuration - Set CONFIG_ZMK_BATTERY_REPORTING_FETCH_MODE_LITHIUM_VOLTAGE=y
Change reference to the upstream driver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #3248, move to the upstream zephyr driver. Have been testing this on a custom board without any issues.
I tried my best to update everything correctly but can't test any of the boards updated.
Additional question, do we want to set
power-on-sample-delay-usto 10000 to match the old zmk driver for these boards?PR check-list