Using MZ_COMPAT doesn't match old Minizip output#862
Using MZ_COMPAT doesn't match old Minizip output#862AndrewAtAvenza wants to merge 1 commit intozlib-ng:developfrom
Conversation
…in cmake package * Added missing 'crypt.h' (from 'compat/crypt.h') when installing after building with MZ_COMPAT
| install(TARGETS ${MINIZIP_TARGET} ${MINIZIP_DEP} | ||
| EXPORT ${MINIZIP_TARGET} | ||
| INCLUDES DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}/${MINIZIP_TARGET}" | ||
| INCLUDES DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}" |
There was a problem hiding this comment.
I wonder what the historial reason for ${MINIZIP_TARGET} is here? Can you check? I'm not feeling well.
There was a problem hiding this comment.
Perhaps we should remove this change here as it could affect Linux distributions?
There was a problem hiding this comment.
Say if a target has both minizip-ng and minizip-compat? It would then create two dirs??
There was a problem hiding this comment.
Maybe we can add multiple INCLUDES DESTINATIONS?
There was a problem hiding this comment.
That would also work. The main problem is that if you have
#include <minizip/zip.h>and zip.h is at /minizip/install/path/minizip/zip.h and the only include path is /minizip/install/path/minizip, it won't find it. Hence the need to drop the minizip or minizip-ng at the end.
Coeur
added
compilation
4 participants
Resolves #861