fix(signer): fix sendTransaction populating from address

zksync-sdk · Feb 12, 2025 · 2f18080 · 2f18080
1 parent 7bf3400
commit 2f18080
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/src/signer.ts b/src/signer.ts
@@ -647,19 +647,22 @@ export class Signer extends AdapterL2(ethers.JsonRpcSigner) {
   override async sendTransaction(
     transaction: TransactionRequest
   ): Promise<TransactionResponse> {
+    if (!transaction.type) {
+      transaction.type = EIP712_TX_TYPE;
+    }
+    const address = await this.getAddress();
+    transaction.from ??= address;
     const tx = await this.populateFeeData(transaction);
+    if (!isAddressEq(await ethers.resolveAddress(tx.from!), address)) {
+      throw new Error('Transaction `from` address mismatch!');
+    }
 
     if (
       tx.type === null ||
       tx.type === undefined ||
       tx.type === EIP712_TX_TYPE ||
       tx.customData
     ) {
-      const address = await this.getAddress();
-      tx.from ??= address;
-      if (!isAddressEq(await ethers.resolveAddress(tx.from), address)) {
-        throw new Error('Transaction `from` address mismatch!');
-      }
       const zkTx: TransactionLike = {
         type: tx.type ?? EIP712_TX_TYPE,
         value: tx.value ?? 0,