Skip to content

Conversation

@saleel
Copy link
Member

@saleel saleel commented Sep 3, 2025

Resolves #14

Summary by CodeRabbit

  • Chores

    • Bumped package version to 0.5.0.
    • Updated multiple dependencies to newer versions, including RSA, SHA256, Base64, string search, and bignum libraries.
    • Updated minimum Noir version requirement to v1.0.0-beta.11 in CI/CD workflows.
  • Style

    • Improved code formatting.

@coderabbitai
Copy link

coderabbitai bot commented Nov 13, 2025

Walkthrough

This PR updates the project's minimum Noir version to v1.0.0-beta.11 in CI, bumps the package version to 0.5.0, updates six dependencies (rsa, sha256, base64, string_search, bignum, nodash) to newer versions, and migrates the RSA dependency source from noir-lang to zkpassport. Minor formatting changes are applied in lib.nr.

Changes

Cohort / File(s) Summary
CI Configuration
​.github/workflows/test.yml
Environment variable MINIMUM_NOIR_VERSION bumped from v1.0.0-beta.4 to v1.0.0-beta.11
Dependency Manifest
​Nargo.toml
Package version incremented from 0.4.3 to 0.5.0; dependencies updated: rsa (v0.7.0→v0.9.1, source changed to zkpassport/noir_rsa), sha256 (v0.1.2→v0.2.1), base64 (v0.4.0→v0.4.2), string_search (v0.3.2→v0.3.3), bignum (v0.6.0→v0.8.0), nodash (v0.41.1→v0.42.0)
Source Formatting
​src/lib.nr
Needle variable initialization reformatted across multiple lines; no functional changes

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Attention areas: Verify that the rsa source migration from noir-lang to zkpassport/noir_rsa and the version bumps to dependencies (particularly bignum v0.6.0→v0.8.0 and rsa v0.7.0→v0.9.1) are compatible and align with the nightly Noir compilation fixes referenced in linked issue #14.

Poem

🐰 Versions hop and dance up high,
From beta.4 to beta.11 we fly!
Dependencies refresh with newfound grace,
RSA finds a new dwelling place.
Strings aligned, the library's set—
Ready for tests, no more regret! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR updates dependencies and Noir version, but the linked issue requires code changes to fix compilation errors (type annotations, imports, API usage adjustments); these fixes are not present in the changeset. In addition to dependency updates, implement required code changes such as adding type annotations, updating imports, and adapting to Noir std/hash API changes to resolve compilation failures.
Title check ❓ Inconclusive The title 'chore: update deps' is partially related to the changeset but doesn't capture the critical objective of fixing compilation failures on Noir nightly. Consider a more specific title like 'chore: update deps and noir version for nightly compatibility' to clarify that this addresses compilation issues.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Out of Scope Changes check ✅ Passed All changes (dependency bumps, version update, minor formatting) are related to the objective of updating the library for Noir nightly compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch saleel/deps-update-beta11

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 899ff2c and 708f799.

📒 Files selected for processing (3)
  • .github/workflows/test.yml (1 hunks)
  • Nargo.toml (1 hunks)
  • src/lib.nr (2 hunks)
🔇 Additional comments (4)
src/lib.nr (1)

244-246: Formatting change only; verify compilation issues are resolved by dependency updates alone.

The needle variable initialization is split across lines for readability, but this formatting change doesn't address the compilation failures described in the issue (missing hash functions, type-dispatch errors, trait imports). Ensure the dependency updates in Nargo.toml fully resolve all stated compilation errors when run against nightly Noir.

Also applies to: 332-334

Nargo.toml (2)

9-15: Verify rsa source migration is intentional.

The rsa dependency source is changing from noir-lang to zkpassport/noir_rsa. This represents a shift to a different maintainer. Confirm that:

  1. This change is intentional and aligns with the library's maintenance strategy.
  2. The zkpassport/noir_rsa v0.9.1 maintains API compatibility with the previous noir-lang version.
  3. There are no breaking changes in the public API of the rsa module being used by this library.

Consider documenting this source migration in the commit message or PR description for future maintainers.


4-4: Version bump to 0.5.0 is appropriate.

The minor version bump reflects the dependency updates with potential breaking changes in the Noir toolchain. This signals downstream consumers to review compatibility.

.github/workflows/test.yml (1)

11-11: LGTM.

The minimum Noir version update to v1.0.0-beta.11 aligns with the dependency updates and PR objective. CI will now test against the minimum supported version and nightly, ensuring compatibility is maintained.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Library does not compile on nightly version of Noir.

3 participants