Skip to content

Conversation

@benceharomi
Copy link
Contributor

@benceharomi benceharomi commented Oct 20, 2025

Summary by CodeRabbit

  • Refactor
    • Improved Twitter proof generation by switching to an updated blueprint and streamlining circuit initialization for more reliable proofs.
  • Chores
    • Upgraded a core SDK dependency to a newer major release to align with the updated blueprint and runtime.

@coderabbitai
Copy link

coderabbitai bot commented Oct 20, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Dependency updated for @zk-email/sdk; Twitter proof utility switched its blueprint source from v2 to v1 and removed the custom noir circuit loader, now using the blueprint's default noir circuit.

Changes

Cohort / File(s) Summary
Dependency update
package.json
Upgraded @zk-email/sdk from 2.0.1-7 to 3.0.0-nightly.11.
Blueprint & circuit refactor
src/features/twitter/useTwitterProof.ts
Switched blueprint reference to benceharomi/x_handle@v1 (was v2); removed the custom getNoirCircuit override so the blueprint's default noir circuit is used.

Sequence Diagram(s)

sequenceDiagram
  participant App
  participant UseTwitterProof
  participant BlueprintRepo
  participant Prover

  rect rgb(240,248,255)
  Note right of UseTwitterProof: Old flow (before change)
  UseTwitterProof->>BlueprintRepo: fetch blueprint v2 + custom noir circuit loader
  BlueprintRepo-->>UseTwitterProof: blueprint v2 + noir circuit (custom)
  UseTwitterProof->>Prover: create prover with custom circuit
  Prover-->>UseTwitterProof: proof
  end

  rect rgb(245,255,240)
  Note right of UseTwitterProof: New flow (after change)
  UseTwitterProof->>BlueprintRepo: fetch `benceharomi/x_handle@v1`
  BlueprintRepo-->>UseTwitterProof: blueprint v1 (includes default noir circuit)
  UseTwitterProof->>Prover: create prover with blueprint's default circuit
  Prover-->>UseTwitterProof: proof
  end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Pay attention to useTwitterProof.ts for changes in blueprint source and removal of the custom circuit loader.
  • Verify package.json dependency bump and any peer/dependency compatibility implications in CI/build scripts.

Poem

🐰 A night-release hop, a tidy shift,
Blueprint v1 now leads the rift—
No noir loader hiding near,
The default circuit crystals clear. ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main changes: updating to use the dev registry blueprint for X handle circuit and upgrading dependencies.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bence/sol-258-use-dev-registry-for-email-as-ens

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d3689b7 and a869fa6.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@benceharomi benceharomi changed the title feat: use dev registry blueprint x handle feat: use dev registry blueprint x handle circuit Oct 20, 2025
@benceharomi benceharomi marked this pull request as ready for review October 23, 2025 13:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Twitter proof implementation to use a newer blueprint version and SDK. The changes simplify the circuit loading by removing local override logic and updating to use the dev registry blueprint.

Key Changes:

  • Updated blueprint reference from benceharomi/X_HANDLE@v2 to benceharomi/x_handle@v1
  • Removed custom local Noir circuit loading logic
  • Upgraded @zk-email/sdk from version 2.0.1-7 to 3.0.0-nightly.1

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/features/twitter/useTwitterProof.ts Simplified blueprint retrieval by removing custom circuit loader and updating blueprint identifier
package.json Updated SDK dependency to nightly version

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants