-
Notifications
You must be signed in to change notification settings - Fork 0
feat: use dev registry blueprint x handle circuit #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughDependency updated for Changes
Sequence Diagram(s)sequenceDiagram
participant App
participant UseTwitterProof
participant BlueprintRepo
participant Prover
rect rgb(240,248,255)
Note right of UseTwitterProof: Old flow (before change)
UseTwitterProof->>BlueprintRepo: fetch blueprint v2 + custom noir circuit loader
BlueprintRepo-->>UseTwitterProof: blueprint v2 + noir circuit (custom)
UseTwitterProof->>Prover: create prover with custom circuit
Prover-->>UseTwitterProof: proof
end
rect rgb(245,255,240)
Note right of UseTwitterProof: New flow (after change)
UseTwitterProof->>BlueprintRepo: fetch `benceharomi/x_handle@v1`
BlueprintRepo-->>UseTwitterProof: blueprint v1 (includes default noir circuit)
UseTwitterProof->>Prover: create prover with blueprint's default circuit
Prover-->>UseTwitterProof: proof
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Twitter proof implementation to use a newer blueprint version and SDK. The changes simplify the circuit loading by removing local override logic and updating to use the dev registry blueprint.
Key Changes:
- Updated blueprint reference from
benceharomi/X_HANDLE@v2tobenceharomi/x_handle@v1 - Removed custom local Noir circuit loading logic
- Upgraded
@zk-email/sdkfrom version2.0.1-7to3.0.0-nightly.1
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/features/twitter/useTwitterProof.ts | Simplified blueprint retrieval by removing custom circuit loader and updating blueprint identifier |
| package.json | Updated SDK dependency to nightly version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Summary by CodeRabbit