Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zk config alias, resolves feature request in issue #253. #484

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

andrebauer
Copy link

@andrebauer andrebauer commented Dec 25, 2024

zk config alias lists the aliases in the configuration file.

Closes #253.

@tjex
Copy link
Member

tjex commented Jan 3, 2025

Thanks for this :) Having an initial look at it now. May be a bit slow as I'm starting a new job next week.

My initial thoughts is that it would be good to structure this config.go file in a way that makes it simple to add new config commands.

In line with that I don't think zk config should list out the aliases. It should be zk config --list aliases or something to that effect.

There are no doubt future use cases for zk config ... commands, so starting out with that in mind will pay dividends down the track.

If you're not up for restructuring yourself, not a worry. I can look at it at some point 👍

This is excellent ground work as it is :) Thanks again.

A secondary thought could be to refactor the logic for cmd.header, cmd.delimter, etc into a function somewhere instead of copying from cmd.List. But maybe thats too soon of an optimization.

…guration objects like aliases, filters or extras.
@andrebauer
Copy link
Author

If have reworked the zk config so that zk config --list OBJECT now list the aliases, filters or extras. For further improvements I ask you to give me more specific suggestions.

Especially for the copied logic from cmd.List, the question would be to which file that should be transferred. But this may already be a separate issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Command to list all aliases
2 participants