fix: detect lost collection and return error instead of empty results on search#281
Merged
zc277584121 merged 1 commit intozilliztech:masterfrom Mar 11, 2026
Conversation
… on search Signed-off-by: Cheney Zhang <chen.zhang@zilliz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a Milvus collection is deleted externally (e.g., cloud sync failure, manual cleanup) but the local snapshot still marks the codebase as indexed,
search_codepreviously returned a misleading "No results found" message. Users couldn't distinguish between "no matching code" and "index data is gone".This PR adds a collection existence check when search returns 0 results: if the local snapshot says "indexed" but the collection no longer exists in Milvus, it now returns an explicit error message telling the user to re-index with
force=true.Changes
packages/mcp/src/handlers.ts: Added 12 lines inhandleSearchCode()to checkhasCollection()when search returns empty results and local snapshot shows indexed statusBehavior
!isIndexing)Test plan
pnpm build:mcpsucceeds