Skip to content

fix: empty filter query and cloud sync deletion bugs (#279, #251)#280

Merged
zc277584121 merged 1 commit intozilliztech:masterfrom
zc277584121:fix/sync-and-empty-filter-bug
Mar 11, 2026
Merged

fix: empty filter query and cloud sync deletion bugs (#279, #251)#280
zc277584121 merged 1 commit intozilliztech:masterfrom
zc277584121:fix/sync-and-empty-filter-bug

Conversation

@zc277584121
Copy link
Collaborator

Summary

  • Fix empty string filter in vectorDb.query() causing empty results on both gRPC and REST clients by omitting the filter field instead of sending ""
  • Store codebasePath in collection description (codebasePath:<path> format) for reliable extraction during sync, with fallback to query-based extraction for backward compatibility with old collections
  • Add safety guards in syncIndexedCodebasesFromCloud(): skip deletion when collections list is empty or all extractions fail, preventing accidental deletion of all local indexed codebases
  • Add getCollectionDescription() to VectorDatabase interface with implementations for both MilvusVectorDatabase and MilvusRestfulVectorDatabase
  • Fix REST API createCollection/createHybridCollection to pass description parameter (was previously ignored)
  • Bump version to 0.1.4

Changes

File Change
packages/core/src/vectordb/types.ts Add getCollectionDescription to interface
packages/core/src/vectordb/milvus-vectordb.ts Fix empty filter, implement getCollectionDescription
packages/core/src/vectordb/milvus-restful-vectordb.ts Fix empty filter, pass description in create, implement getCollectionDescription
packages/core/src/context.ts Change collection description format to codebasePath:<path>
packages/mcp/src/handlers.ts Refactor sync: description-first extraction with query fallback and safety guards
*/package.json Version bump 0.1.3 → 0.1.4

Test plan

…illiztech#251)

- Fix empty string filter in vectorDb.query() causing empty results on both
  gRPC and REST clients by omitting the filter field instead of sending ""
- Store codebasePath in collection description for reliable extraction
  during sync, with fallback to query-based extraction for old collections
- Add safety guards in syncIndexedCodebasesFromCloud: skip deletion when
  collections list is empty or all extractions fail
- Add getCollectionDescription to VectorDatabase interface with
  implementations for both MilvusVectorDatabase and MilvusRestfulVectorDatabase
- Fix REST API createCollection/createHybridCollection to pass description
- Bump version to 0.1.4

Signed-off-by: Cheney Zhang <chen.zhang@zilliz.com>
@zc277584121 zc277584121 merged commit 03a83a1 into zilliztech:master Mar 11, 2026
4 checks passed
@zc277584121 zc277584121 deleted the fix/sync-and-empty-filter-bug branch March 11, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant