fix: empty filter query and cloud sync deletion bugs (#279, #251)#280
Merged
zc277584121 merged 1 commit intozilliztech:masterfrom Mar 11, 2026
Merged
Conversation
…illiztech#251) - Fix empty string filter in vectorDb.query() causing empty results on both gRPC and REST clients by omitting the filter field instead of sending "" - Store codebasePath in collection description for reliable extraction during sync, with fallback to query-based extraction for old collections - Add safety guards in syncIndexedCodebasesFromCloud: skip deletion when collections list is empty or all extractions fail - Add getCollectionDescription to VectorDatabase interface with implementations for both MilvusVectorDatabase and MilvusRestfulVectorDatabase - Fix REST API createCollection/createHybridCollection to pass description - Bump version to 0.1.4 Signed-off-by: Cheney Zhang <chen.zhang@zilliz.com>
This was referenced Mar 11, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vectorDb.query()causing empty results on both gRPC and REST clients by omitting the filter field instead of sending""codebasePathin collection description (codebasePath:<path>format) for reliable extraction during sync, with fallback to query-based extraction for backward compatibility with old collectionssyncIndexedCodebasesFromCloud(): skip deletion when collections list is empty or all extractions fail, preventing accidental deletion of all local indexed codebasesgetCollectionDescription()toVectorDatabaseinterface with implementations for bothMilvusVectorDatabaseandMilvusRestfulVectorDatabasecreateCollection/createHybridCollectionto pass description parameter (was previously ignored)Changes
packages/core/src/vectordb/types.tsgetCollectionDescriptionto interfacepackages/core/src/vectordb/milvus-vectordb.tsgetCollectionDescriptionpackages/core/src/vectordb/milvus-restful-vectordb.tsgetCollectionDescriptionpackages/core/src/context.tscodebasePath:<path>packages/mcp/src/handlers.ts*/package.jsonTest plan
codebasePath:prefix handled via fallbackpnpm build:coreandpnpm build:mcpboth succeed