fix(mcp): handle non-string metadata in cloud sync handler#270
Open
DelphiaDan wants to merge 1 commit intozilliztech:masterfrom
Open
fix(mcp): handle non-string metadata in cloud sync handler#270DelphiaDan wants to merge 1 commit intozilliztech:masterfrom
DelphiaDan wants to merge 1 commit intozilliztech:masterfrom
Conversation
LanceDB returns metadata as a parsed JS object, but the cloud sync handler calls JSON.parse() unconditionally. This throws on non-string input, causing the codebase path to never register — so search_code reports "codebase not indexed" after successful indexing. Add a type guard to only parse when metadata is a string. Fixes zilliztech#226
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codebasePathmetadatamay already be a parsed JS object rather than a JSON stringJSON.parse()is called unconditionally on line 86, which throws when the value is not a stringsearch_codereports "codebase not indexed" even after successful indexingFix
Add a type guard to only parse when metadata is actually a string:
Fixes #226