Fixes according to ziglang/zig#30644 #64
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://codeberg.org/ziglang/zig/pulls/30644 The global `os.environ` is no longer available, and environment data need to be explicitly passed along like `io` and `allocator`. I've tried my best to adhere to the principles and make as few disruptive incisions as possible, but there are one noteworthy exception: `DefaultSystem` has an internal arena allocator backed by std.heap.page_allocator` in order to satisfy the condition of the caller not owning the memory. This means that `getenv` no longer need the allocator parameter.
Member
|
There are some things that I would request to be changed in this PR:
To avoid any further delays in getting this project updated, I already implemented this in #65. Thank you nonetheless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://codeberg.org/ziglang/zig/pulls/30644
The global
os.environis no longer available, and environment data need to be explicitly passed along likeioandallocator.I've tried my best to adhere to the principles and make as few disruptive incisions as possible, but there are one noteworthy exception:
DefaultSystemhas an internal arena allocator backed bystd.heap.page_allocatorin order to satisfy the condition of the caller not owning the memory. This means thatgetenvno longer need the allocator parameter.