Skip to content

Conversation

@mateusz834
Copy link
Contributor

At the beginning of structDeclInner there is a special path that handles tuples, we don't have to do anything special here.

At the beginning of structDeclInner there is a special path that handles
tuples, we don't have to do anything special here.
@mateusz834 mateusz834 force-pushed the dont-call-convertToNonTupleLike-in-structDeclInner branch from e66fc64 to 8708d88 Compare November 9, 2025 17:42
@mateusz834 mateusz834 changed the title std.zig.AstGen: don't call convertToNonTupleLike in structDeclInner. std.zig.AstGen: don't call convertToNonTupleLike in structDeclInner Nov 9, 2025
@alexrp alexrp requested a review from mlugg November 9, 2025 18:15
@mateusz834
Copy link
Contributor Author

I also have a feeling that the convertToNonTupleLike makes the code hard to reason about, i removed them in https://github.com/ziglang/zig/compare/ziglang:zig:master...mateusz834:zig:remove-convertToNonTupleLike?expand=1

Let me know what you think about this, i can put these commits also here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant