libc: implement common abs for various integer sizes
#23893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrp
reviewed
May 15, 2025
alexrp
reviewed
May 15, 2025
jayschwa
reviewed
May 15, 2025
| } | ||
|
|
||
| fn abs(a: c_int) callconv(.c) c_int { | ||
| return if (a > 0) a else -a; |
There was a problem hiding this comment.
Why this way instead of return @abs(a)?
There was a problem hiding this comment.
I think to remember to have read somewhere that an implementation similar to musl is recommended. @abs didn't come to my mind
There was a problem hiding this comment.
There is no such constraint. As long as it's functionally compatible with the musl implementation, you're free to implement it in a more "Ziggy" way.
That means you can delete the duplicate libc implementations. |
kada49
force-pushed
the
common-impl-libc-abs
branch
from
e730278 to
4bbb5df
Compare
alexrp
reviewed
May 17, 2025
Comment on lines
+19
to
+20
| _ = @import("c/inttypes.zig"); | ||
| _ = @import("c/stdlib.zig"); |
There was a problem hiding this comment.
These should be moved outside this check, and appropriate checks should be added around the @exports instead.
Context: #23847 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented common libc functions:
absimaxabslabsllabsabs functions for floating point numbers are already implemented in compiler_rt.