Skip to content

Fix sentinel value not being set in runtime array init#23882

Closed
rockssalt05 wants to merge 3 commits intoziglang:masterfrom
rockssalt05:sentinel-bug
Closed

Fix sentinel value not being set in runtime array init#23882
rockssalt05 wants to merge 3 commits intoziglang:masterfrom
rockssalt05:sentinel-bug

Conversation

@rockssalt05
Copy link

Closes #23739

@alexrp
Copy link
Member

alexrp commented May 14, 2025

This should come with a behavior test in test/behavior/array.zig.

@alexrp alexrp requested a review from mlugg May 14, 2025 14:03
@mlugg
Copy link
Member

mlugg commented May 15, 2025

All fine, except a style nit, which I just committed myself. I'll set this to auto-merge now (squash, so don't worry about my bad automatic commit message) -- thanks!

@mlugg mlugg enabled auto-merge (squash) May 15, 2025 15:43
@mlugg mlugg added this to the 0.14.1 milestone May 15, 2025
@alexrp
Copy link
Member

alexrp commented May 15, 2025

Those LLVM backend failures will need fixing for this to make it in time for 0.14.1.

@alexrp alexrp removed this from the 0.14.1 milestone May 18, 2025
@andrewrk
Copy link
Member

This pull request is not ready for review because:

  • It has conflicts that must be resolved via rebasing against latest origin/master.
  • It is not passing the CI tests.
  • No response to core team feedback.

Closing since there has been no activity for 30+ days.

@andrewrk andrewrk closed this Nov 27, 2025
auto-merge was automatically disabled November 27, 2025 02:41

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sentinel value isn't set when array is initialized

4 participants