Add a first gRPC implementation choice#140
Open
agagniere wants to merge 6 commits intozig-o11y:mainfrom
Open
Conversation
Collaborator
|
Time to rebase here :) |
because the environment is read and a real OTLP endpoint may be targeted
agagniere
commented
Apr 2, 2026
|
|
||
| fn grpcPath(self: Self) []const u8 { | ||
| switch (self) { | ||
| .metrics => return "/opentelemetry.proto.collector.metrics.v1.MetricsService/Export", |
Contributor
Author
There was a problem hiding this comment.
With zig-protobuf's service generation we will be able to generate this at comptime if desired
EDIT: when we will target Zig 0.16
Collaborator
There was a problem hiding this comment.
Have you tried incorporating Arwalk/zig-protobuf to generate structs for Services?
Not saying we should do it in this PR, also because the service generation code is not yet released, it is only found in zig-master branch, targeting 0.16.0.
Just curious if we are referring to the same thing or not.
Contributor
Author
There was a problem hiding this comment.
Yes I did it in my master branch targeting 0.16.
Here I'm using my zig-0.15 branch
Contributor
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #102
Stacked on top of #139