Divide itmmorgue to different modules #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Leave main entry point logic in itmmorgue.c; - Add error module; - Add ioutils module; - Add logger module; - Add strutils; - Add time module; Reason of refactoring is that itmmorgue.c contains entry point and implementation of often used functions. Furthermore it is bunch of mixed logic in one file and it's better to follow single responsibility principle.
csepanda
requested review from
adduxa,
ValeriyKr and
zhmylove
as code owners
|
@ValeriyKr что будем делать с #56 ? |
|
Как по мне, так я не уверен, что всё это нужно. К тому же приписывание "utils"
ко всем подряд файлам мне не нравится. Лишнее загромождение списка файлов.
…On 03/23/2018 09:45 PM, Sergey Zhmylove wrote:
@ValeriyKr </ValeriyKr> что будем делать с #56
<#56> ?
В принципе, особо хуже он не делает, я считаю.
Но лучше семь раз подумать и один раз отрезать.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#56 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AM26gIfwtPWgS3Y8mbQ2ZG0J0iyaPtKhks5thUKtgaJpZM4SJUe8>.
--
Kind regards,
Valeriy Kireev
Software developer -- TuneIT Company.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason of refactoring is that itmmorgue.c contains entry point
and implementation of often used functions. Furthermore
it is bunch of mixed logic in one file and it's better to follow
single responsibility principle.