Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds testing #87

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Adds testing #87

wants to merge 4 commits into from

Conversation

zgosalvez
Copy link
Owner

No description provided.

@bartosz347
Copy link
Contributor

@zgosalvez On the subject of the upgrade of lcov-total to v2, there are at least 2 options:

  1. Migrate whole project to ESM (I'm not sure if ESM is supported by GitHub Actions and ncc)
  2. Use import like described here.

This quick PoC seems to work with Node directly (an isolated run of only a single function), but Jest is throwing an error.

async function foo() {
  const lcovTotal = await import('lcov-total/src/index.js');

  lcovTotal.default("foo-file");
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants