Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: remove redundant 'virtual' for the 'override'-specified functions #662

Merged
merged 1 commit into from
Jan 26, 2025
+5 −5
Merged

style: remove redundant 'virtual' for the 'override'-specified functions #662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/test_dom_traverse.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,7 +896,7 @@ struct test_walker: xml_tree_walker
#endif
}

virtual bool begin(xml_node& node) PUGIXML_OVERRIDE
bool begin(xml_node& node) PUGIXML_OVERRIDE
{
log += STR("|");
log += depthstr();
Expand All @@ -908,7 +908,7 @@ struct test_walker: xml_tree_walker
return ++call_count != stop_count && xml_tree_walker::begin(node);
}

virtual bool for_each(xml_node& node) PUGIXML_OVERRIDE
bool for_each(xml_node& node) PUGIXML_OVERRIDE
{
log += STR("|");
log += depthstr();
Expand All @@ -920,7 +920,7 @@ struct test_walker: xml_tree_walker
return ++call_count != stop_count && xml_tree_walker::end(node);
}

virtual bool end(xml_node& node) PUGIXML_OVERRIDE
bool end(xml_node& node) PUGIXML_OVERRIDE
{
log += STR("|");
log += depthstr();
Expand Down
4 changes: 2 additions & 2 deletions tests/test_write.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ struct test_writer: xml_writer
{
std::basic_string<char_t> contents;

virtual void write(const void* data, size_t size) PUGIXML_OVERRIDE
void write(const void* data, size_t size) PUGIXML_OVERRIDE
{
CHECK(size % sizeof(char_t) == 0);
contents.append(static_cast<const char_t*>(data), size / sizeof(char_t));
Expand Down Expand Up @@ -687,7 +687,7 @@ TEST(write_flush_coverage)
#ifndef PUGIXML_NO_EXCEPTIONS
struct throwing_writer: xml_writer
{
virtual void write(const void*, size_t) PUGIXML_OVERRIDE
void write(const void*, size_t) PUGIXML_OVERRIDE
{
throw std::runtime_error("write failed");
}
Expand Down
Loading