Merge pull request #662 from e-kwsm/virtual

style: remove redundant 'virtual' for the 'override'-specified functions
zeux · Jan 26, 2025 · a305d01 · a305d01
2 parents 9d7fcbf + 081e8a3
commit a305d01
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/tests/test_dom_traverse.cpp b/tests/test_dom_traverse.cpp
@@ -896,7 +896,7 @@ struct test_walker: xml_tree_walker
 	#endif
 	}
 
-	virtual bool begin(xml_node& node) PUGIXML_OVERRIDE
+	bool begin(xml_node& node) PUGIXML_OVERRIDE
 	{
 		log += STR("|");
 		log += depthstr();
@@ -908,7 +908,7 @@ struct test_walker: xml_tree_walker
 		return ++call_count != stop_count && xml_tree_walker::begin(node);
 	}
 
-	virtual bool for_each(xml_node& node) PUGIXML_OVERRIDE
+	bool for_each(xml_node& node) PUGIXML_OVERRIDE
 	{
 		log += STR("|");
 		log += depthstr();
@@ -920,7 +920,7 @@ struct test_walker: xml_tree_walker
 		return ++call_count != stop_count && xml_tree_walker::end(node);
 	}
 
-	virtual bool end(xml_node& node) PUGIXML_OVERRIDE
+	bool end(xml_node& node) PUGIXML_OVERRIDE
 	{
 		log += STR("|");
 		log += depthstr();

diff --git a/tests/test_write.cpp b/tests/test_write.cpp
@@ -237,7 +237,7 @@ struct test_writer: xml_writer
 {
 	std::basic_string<char_t> contents;
 
-	virtual void write(const void* data, size_t size) PUGIXML_OVERRIDE
+	void write(const void* data, size_t size) PUGIXML_OVERRIDE
 	{
 		CHECK(size % sizeof(char_t) == 0);
 		contents.append(static_cast<const char_t*>(data), size / sizeof(char_t));
@@ -687,7 +687,7 @@ TEST(write_flush_coverage)
 #ifndef PUGIXML_NO_EXCEPTIONS
 struct throwing_writer: xml_writer
 {
-	virtual void write(const void*, size_t) PUGIXML_OVERRIDE
+	void write(const void*, size_t) PUGIXML_OVERRIDE
 	{
 		throw std::runtime_error("write failed");
 	}