adding changeset #208
adding changeset #208
Conversation
| ```bash | ||
| changeset | ||
| ``` |
There was a problem hiding this comment.
A command changeset is not added to my PATH by npm install. Is there some setup missing from this README?
Note that Changesets documents npx @changesets/cli instead of a command changeset.
There was a problem hiding this comment.
i've adjusted the package.lock file to include all of these changeset commands referenced in the README and adjusted the README to include npm run commands instead.
Can you confirm that this works as documented now @WULCAN ?
| "lyra" | ||
| ], | ||
| "devDependencies": { | ||
| "@changesets/cli": "^2.29.4", |
There was a problem hiding this comment.
Our package-lock is not fully updated after this change. Let's add the changes npm install does to our package-lock.
webapp/CHANGELOG.md
Outdated
| ## 0.4.1 | ||
|
|
||
| ### Patch Changes | ||
|
|
||
| - Added changesets | ||
|
|
There was a problem hiding this comment.
0.4.1 is already tagged, it's too late to add changesets to 0.4.1 now.
There was a problem hiding this comment.
now even more time has passed and it's gonna be 0.7.1
webapp/package.json
Outdated
| { | ||
| "name": "lyra-webapp", | ||
| "version": "0.4.0", | ||
| "version": "0.4.1", |
There was a problem hiding this comment.
Our package-lock is not updated after this change. Please add the changes npm install does to our package-lock.
Signed-off-by: Alexander Schreiner <[email protected]>
xela1601
force-pushed
the
issue-200/add-changesets
branch
from
bb8acd1 to
8bc4959
Compare
2 participants
Description
This PR introduced changesets
Changes
[Add a list of features added/changed, bugs fixed etc]
Related issues
Resolves #200