Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: add serum.h to installation files #56

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

jsm174
Copy link
Contributor

@jsm174 jsm174 commented Jul 3, 2024

libserum fails to build in Batocera-linux since the header file was not being copied.

@zesinger
Copy link
Owner

zesinger commented Jul 3, 2024

Not sure I'm right, but for me the release is for players not for coders, so adding many files in the release is not a good option. For the coders, everything is available in the source code https://github.com/zesinger/libserum/tree/main/src . Don't you think?

@jsm174
Copy link
Contributor Author

jsm174 commented Jul 3, 2024

batocera builds all of it's libraries before they bundle it and release it.

Since serum.h is not copied over to the includes, libdmdutil fails to build:

So here's what we get:

image

This PR will fix that

@zesinger
Copy link
Owner

zesinger commented Jul 3, 2024

OK

@zesinger zesinger merged commit 5329017 into zesinger:main Jul 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants