You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Beyond CI — what did you manually verify? Checked the broken stale gettext shapes in the existing .po catalogs, confirmed the matching fenced English msgids are gone from source, and reviewed the changed docs for clarity and consistency.
If any command was intentionally skipped, why: Full cargo mdbook build was not run; this is a docs-source-only slice, and mdBook/Cargo builds are a broader rendered-warning validation boundary.
Security & Privacy Impact (required)
New permissions, capabilities, or file system access scope? No
New external network calls? No
Secrets / tokens / credentials handling changed? No
PII, real identities, or personal data in diff, tests, fixtures, or docs? No
If any Yes, describe the risk and mitigation: N/A
Compatibility (required)
Backward compatible? Yes
Config / env / CLI surface changed? No
If No or Yes to either: N/A
Rollback (required for risk: medium and risk: high)
Draft, docs-only, direction only, no verdict. I read both files.
Direction notes:
The conversion is sound where the content is a single short token: the nextcloud-talk webhook URL reads fine as an inline span, and the first delegation refusal is borderline but acceptable inline.
The two long delegation refusal strings (the reachability one and the escalation one) are full sentences with embedded placeholders. As inline code spans they will render as one unbroken monospace run that does not soft-wrap cleanly in a narrow mdbook column, where a fenced block would have wrapped or scrolled. If the only goal is to stop the translation-staleness linter from treating these as translatable placeholder blocks, confirm that an inline span actually exempts them; if the linter keys on backtick content generally, you may have just moved the problem. Worth verifying the warning is actually gone on the rendered output before flipping out of draft.
If the linter is specifically flagging fenced blocks with no language tag, the alternative is to tag them (```text is already there on two of them) rather than collapse to inline. That keeps the block presentation for the long strings. Either direction is fine, but pick based on what the linter actually keys on rather than guessing.
Confirm the warning is gone post-render, then this is a clean docs change. Flag me when it is ready for a verdict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
master.potranslations that dropped code fences and exposed<target>,<caller>, and URL placeholders as raw HTML..pocatalog edits, generated reference changes, runtime changes, or translation-tool changes.Validation Evidence (required)
No output; passed.
Output:
Output:
Tail output:
.pocatalogs, confirmed the matching fenced Englishmsgids are gone from source, and reviewed the changed docs for clarity and consistency.cargo mdbook buildwas not run; this is a docs-source-only slice, and mdBook/Cargo builds are a broader rendered-warning validation boundary.Security & Privacy Impact (required)
NoNoNoNoYes, describe the risk and mitigation: N/ACompatibility (required)
YesNoNoorYesto either: N/ARollback (required for
risk: mediumandrisk: high)Low-risk PR:
git revert <sha>.