Skip to content

Conversation

@JMY787
Copy link

@JMY787 JMY787 commented Oct 19, 2025

Thank you for making a pull request to ZTM's Animation Nation project. We will review your pull request as soon as we can, but keep in mind we can get very busy during Hacktoberfest.

While you're waiting, please look over this checklist. Feel free to write a description of what you did as well!

What I did

Optional: Edit this to tell us what you did!

Pull request checklist

  • This pull request uses HTML and CSS only and provides a meta.json file.
  • All files in this pull request are in a directory named: <github_username>-<art_name> without the <>.
  • Your pull request contains index.html and styles.css.
    • Your html file is named exactly: index.html
    • Your css file is named exactly: styles.css
  • Your pull request your meta.json with:
    • githubHandle: being your unique github user name,
    • artName : name of your animation
  • Your submission includes at least one animation.
  • Your pull request does not modify any other files in the repository.

Not normally needed

  • Check this if you would like to discuss an improvement besides adding animations

Note: if your pull request makes an improvement besides adding a CSS animation you will need to discuss this with the maintainers. You can help kickstart this process by explaining what your change does and why you are making it in the "What I did" section

What to expect

  • If your pull request meets the checklist requirements it will be approved and merged by a maintainer
  • If your pull request needs some changes. A maintainer will leave a comment requesting changes
  • If your pull request significantly violates the criteria in the checklist it will be closed with feedback.

@github-actions github-actions bot added Changes Requested Conflict Present There is a conflict that can't be resolved in the web editor and must be resolved by the user. labels Oct 19, 2025
@LaurelineP LaurelineP assigned LaurelineP and JMY787 and unassigned LaurelineP Oct 20, 2025
@zero-to-mastery zero-to-mastery deleted a comment from github-actions bot Oct 22, 2025
@github-actions
Copy link

Aloha @JMY787 🙌 - Thanks for your contribution!
Before we can merge your submission, please address the following points.

Feedback

Tip

You can refer to README.md for additional guidance.

  • Overall feedback
    Reminder: the contribution should have 3 files in a folder in Art

    • Non-accepted files:
      - please remove the invalid file .DS_Store
    • Incorrect folder name: it should start with your GitHub handle, followed by your art name, inside the Art/ folder.
    • Remove unnecessary file: Art/.DS_Store - this should not be part of your contribution
    • Remove unnecessary file: Art/JMY787-NYY/.DS_Store - not allowed for animations
    • Remove unnecessary file: Art/JMY787-NYY/icon.png - not allowed for animations
  • HTML feedback for Art/JMY787-NYY/index.html

    • Incorrect stylesheet link: update the href so it points to the correct CSS file
    • Incorrect styling approach: please make a stylesheet file out of the style tag
  • CSS feedback for Art/JMY787-NYY/style.css

    • Incorrect filename: please rename as recommended or remove if unnecessary
    • Missing animation: include at least one @keyframes definition and use the animation property
  • JSON feedback for Art/JMY787-NYY/meta.json

    • Invalid JSON structure — please ensure valid JSON format

Happy Coding! 🚀

@zero-to-mastery zero-to-mastery deleted a comment from github-actions bot Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes Requested Conflict Present There is a conflict that can't be resolved in the web editor and must be resolved by the user.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants