drivers: audio: sf32lb52x: audio codec driver #98701

ljq-ctrl · 2025-11-01T10:54:48Z

audio playback and capure, extend API in codec.h

ljq-ctrl · 2025-11-01T11:07:22Z

download code from github very very slow.
Encountered a git problem that cannot be solved
I close the following PR and recommit it refrence
https://docs.zephyrproject.org/latest/contribute/guidelines.html#contribution-workflow

the old PR is:
driver:audio: sf32lb52x:Add onchip codec driver for sf32lb52x platform #97906

drivers/audio/sf32lb_codec.h

JarmouniA · 2025-11-01T16:06:34Z

boards/sifli/sf32lb52_devkit_lcd/sf32lb52_devkit_lcd.yaml

  - uart
  - gpio
  - watchdog
+  - audio-codec


Suggested change

- audio-codec

- audio

it should be used as a tag for some test/sample, otherwise has no utility.
https://docs.zephyrproject.org/latest/develop/test/twister.html#board-configuration

Speaking of which, this driver has to be tested (or at least built) in CI.

boards/sifli/sf32lb52_devkit_lcd/sf32lb52_devkit_lcd.dts

drivers/audio/Kconfig.sf32lb

drivers/audio/sf32lb_codec.h

gmarull

Please make sure to not make unrelated changes into a big commit, split changes into chunks as needed. Also, make sure CI passes and do not open new PRs.

drivers/audio/sf32lb_codec.h

Add more callback in DMA processing, Fix DMA size bug. Signed-off-by: Gang He <[email protected]>

Add audio codec device tree information for sf32lb52x.dtsi Signed-off-by: Gang He <[email protected]>

SF32LB52X audio HAL driver source code is not need in Zephyr driver. Signed-off-by: Gang He <[email protected]>

Support audio device that has both input and output function. Signed-off-by: Gang He <[email protected]>

ck-telecom · 2025-11-02T06:39:32Z

dts/bindings/audio/sifli,sf32lb-audcodec.yaml

@@ -0,0 +1,22 @@
+# Copyright (c) 2025 Qingsong Gou <[email protected]>


why my name :)

ck-telecom · 2025-11-20T06:44:07Z

drivers/audio/sf32lb_codec.c

+
+	pll_calibration(cfg->reg);
+
+	LOG_INF("%s done", __func__);


Suggested change

LOG_INF("%s done", __func__);

ck-telecom · 2025-11-20T06:44:50Z

drivers/audio/sf32lb_codec.c

+	struct sf32lb_audcodec_data *data = dev->data;
+	struct sf32lb_codec_hw_config *hw_cfg = &data->hw_config;
+
+	memset(data, 0, sizeof(struct sf32lb_audcodec_data));


Suggested change

memset(data, 0, sizeof(struct sf32lb_audcodec_data));

ck-telecom · 2025-11-28T06:55:17Z

drivers/audio/sf32lb_codec.c

+#include <zephyr/logging/log.h>
+
+#include <register.h>
+#include <bf0_hal_pmu.h>


Suggested change

#include <bf0_hal_pmu.h>

HAL_PMU_EnableAudio() need it, this func under $root_dir/module/hal/sifli

check #100138 for pmu reigster access

here is this PMU functuon under module/hal/sifli/

HAL_StatusTypeDef HAL_PMU_EnableAudio(int enable) { if (enable) hwp_pmuc->HXT_CR1 |= PMUC_HXT_CR1_BUF_AUD_EN; else hwp_pmuc->HXT_CR1 &= (~PMUC_HXT_CR1_BUF_AUD_EN); return HAL_OK; }

move this function to this file and use sys_write32() ? this will access hwp_pmuc directly
it same that, it better to add audio clock in clock device tree and access PMUC_HXT_CR1_BUF_AUD_EN in clocl_control_sf32lb_rcc.c. codec driver only need to enable the clock by DT

ck-telecom · 2025-11-28T06:55:39Z

drivers/audio/sf32lb_codec.c

+#include <register.h>
+#include <bf0_hal_pmu.h>
+
+LOG_MODULE_REGISTER(siflicodec, CONFIG_AUDIO_CODEC_LOG_LEVEL);


Suggested change

LOG_MODULE_REGISTER(siflicodec, CONFIG_AUDIO_CODEC_LOG_LEVEL);

LOG_MODULE_REGISTER(sifli_codec, CONFIG_AUDIO_CODEC_LOG_LEVEL);

ck-telecom · 2025-11-28T07:03:26Z

drivers/audio/sf32lb_codec.c

+
+static const struct device *codec_dev;
+
+static int config_dac_path(AUDCODEC_TypeDef *reg, uint16_t bypass)


change param coz register access is changed with upper comments

AUDCODEC_TypeDef was defined in $root_dir/module/hal/sifli

a previous version redefined a struct for all register, but it is recommended to use register.h,. so many registers for audio, unless redefined all register as dma_ sf32lb. c, which is prone to errors

ck-telecom · 2025-11-28T07:05:18Z

drivers/audio/sf32lb_codec.c

+	switch (channel) {
+	case 0:
+		reg->DAC_CH0_CFG = (1 << AUDCODEC_DAC_CH0_CFG_ENABLE_Pos)
+			| (0 << AUDCODEC_DAC_CH0_CFG_DOUT_MUTE_Pos)


using FIELD_PREP instead

ck-telecom · 2025-11-28T07:05:42Z

drivers/audio/sf32lb_codec.c

+			| (2 << AUDCODEC_DAC_CH0_CFG_DEM_MODE_Pos)
+			| (0 << AUDCODEC_DAC_CH0_CFG_DMA_EN_Pos)
+			| (6 << AUDCODEC_DAC_CH0_CFG_ROUGH_VOL_Pos)
+			| (0 << AUDCODEC_DAC_CH0_CFG_FINE_VOL_Pos)
+			| (1 << AUDCODEC_DAC_CH0_CFG_DATA_FORMAT_Pos)
+			| (dac_clk->sinc_gain << AUDCODEC_DAC_CH0_CFG_SINC_GAIN_Pos)
+			| (0 << AUDCODEC_DAC_CH0_CFG_DITHER_GAIN_Pos)
+			| (0 << AUDCODEC_DAC_CH0_CFG_DITHER_EN_Pos)
+			| (0 << AUDCODEC_DAC_CH0_CFG_CLK_ANA_POL_Pos);
+
+		reg->DAC_CH0_CFG_EXT = (1 << AUDCODEC_DAC_CH0_CFG_EXT_RAMP_EN_Pos)
+			| (1 << AUDCODEC_DAC_CH0_CFG_EXT_RAMP_MODE_Pos)
+			| (1 << AUDCODEC_DAC_CH0_CFG_EXT_ZERO_ADJUST_EN_Pos)
+			| (2 << AUDCODEC_DAC_CH0_CFG_EXT_RAMP_INTERVAL_Pos)
+			| (0 << AUDCODEC_DAC_CH0_CFG_EXT_RAMP_STAT_Pos);
+
+		reg->DAC_CH0_DEBUG = (0 << AUDCODEC_DAC_CH0_DEBUG_BYPASS_Pos)
+			| (0xFF << AUDCODEC_DAC_CH0_DEBUG_DATA_OUT_Pos);
+
+		break;
+	case 1:
+		reg->DAC_CH1_CFG = (1 << AUDCODEC_DAC_CH0_CFG_ENABLE_Pos)
+			| (0 << AUDCODEC_DAC_CH0_CFG_DOUT_MUTE_Pos)
+			| (2 << AUDCODEC_DAC_CH0_CFG_DEM_MODE_Pos)
+			| (0 << AUDCODEC_DAC_CH0_CFG_DMA_EN_Pos)
+			| (6 << AUDCODEC_DAC_CH0_CFG_ROUGH_VOL_Pos)
+			| (0 << AUDCODEC_DAC_CH0_CFG_FINE_VOL_Pos)
+			| (1 << AUDCODEC_DAC_CH0_CFG_DATA_FORMAT_Pos)
+			| (dac_clk->sinc_gain << AUDCODEC_DAC_CH0_CFG_SINC_GAIN_Pos)
+			| (0 << AUDCODEC_DAC_CH0_CFG_DITHER_GAIN_Pos)
+			| (0 << AUDCODEC_DAC_CH0_CFG_DITHER_EN_Pos)
+			| (0 << AUDCODEC_DAC_CH0_CFG_CLK_ANA_POL_Pos);
+
+		reg->DAC_CH1_CFG_EXT = (1 << AUDCODEC_DAC_CH0_CFG_EXT_RAMP_EN_Pos)
+			| (1 << AUDCODEC_DAC_CH0_CFG_EXT_RAMP_MODE_Pos)
+			| (1 << AUDCODEC_DAC_CH0_CFG_EXT_ZERO_ADJUST_EN_Pos)
+			| (2 << AUDCODEC_DAC_CH0_CFG_EXT_RAMP_INTERVAL_Pos)
+			| (0 << AUDCODEC_DAC_CH0_CFG_EXT_RAMP_STAT_Pos);
+
+		reg->DAC_CH1_DEBUG = (0 << AUDCODEC_DAC_CH0_DEBUG_BYPASS_Pos)
+			| (0xFF << AUDCODEC_DAC_CH0_DEBUG_DATA_OUT_Pos);


same, using FIELD_PREP instead

these was ported from other platform, careful and meticulous modifications are required

ck-telecom · 2025-11-28T07:09:10Z

drivers/audio/sf32lb_codec.c

+	} else {
+		LOG_ERR("dma err");
+	}
+


empty line, run clang format

ck-telecom · 2025-11-28T07:10:55Z

drivers/audio/sf32lb_codec.c

+	static struct sf32lb_audcodec_data data##n = {                             \
+	};                                                                         \


Suggested change

static struct sf32lb_audcodec_data data##n = { \

}; \

static struct sf32lb_audcodec_data data##n; \

samples/drivers/audio/codec/sample.yaml

samples/drivers/audio/codec/src/pcm_data.c

samples/drivers/audio/codec/src/main.c

boards/sifli/sf32lb52_devkit_lcd/sf32lb52_devkit_lcd.dts

audio playback and capure, extend API in codec.h Signed-off-by: ljq-ctrl <[email protected]>

Add audio codec in board device tree, including PA control pin. Signed-off-by: Gang He <[email protected]>

Add audio loop back sample Signed-off-by: ljq-ctrl <[email protected]>

sonarqubecloud · 2025-11-29T05:12:27Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

JarmouniA · 2025-11-29T10:31:54Z

samples/drivers/audio/codec/README.rst

@@ -0,0 +1,30 @@
+.. zephyr:code-sample:: codec
+   :name: codec


Suggested change

:name: codec

:name: audio codec

JarmouniA · 2025-11-29T10:32:11Z

samples/drivers/audio/codec/sample.yaml

+sample:
+  description: onchip audio codec example
+    application
+  name: codec


Suggested change

name: codec

name: audio codec

Addressed

zephyrbot added platform: SF32LB area: Boards/SoCs area: Devicetree Bindings area: Audio labels Nov 1, 2025

zephyrbot requested review from TomasBarakNXP, cameled, ck-telecom, gmarull, kv2019i, lgirdwood and lyakh November 1, 2025 10:56

zephyrbot assigned gmarull Nov 1, 2025

ljq-ctrl mentioned this pull request Nov 1, 2025

driver:audio: sf32lb52x:Add onchip codec driver for sf32lb52x platform #97906

Closed

ljq-ctrl force-pushed the codec branch from 483f0e5 to 7d7f1c0 Compare November 1, 2025 14:20

ljq-ctrl changed the title ~~driver:audio: sf32lb52x:Add onchip codec driver for sf32lb52x platfor…~~ drivers: audio: sf32lb52x: audio codec driver Nov 1, 2025

JarmouniA previously requested changes Nov 1, 2025

View reviewed changes

ljq-ctrl force-pushed the codec branch from 7d7f1c0 to ba8dedc Compare November 3, 2025 03:02

ljq-ctrl requested review from JarmouniA November 3, 2025 06:15

gmarull requested changes Nov 3, 2025

View reviewed changes

drivers/audio/sf32lb_codec.h Outdated Show resolved Hide resolved

ljq-ctrl force-pushed the codec branch 8 times, most recently from 9625992 to 4f8250e Compare November 4, 2025 04:10

ljq-ctrl requested a review from gmarull November 4, 2025 05:17

ljq-ctrl force-pushed the codec branch 2 times, most recently from 7b5e71e to 6953241 Compare November 18, 2025 02:43

gangheivt force-pushed the codec branch 3 times, most recently from 2ed7f60 to a00b251 Compare November 24, 2025 06:33

zephyrbot added the area: Samples Samples label Nov 24, 2025

zephyrbot requested review from kartben and nashif November 24, 2025 06:35

gangheivt force-pushed the codec branch 5 times, most recently from a3b597d to c7eb930 Compare November 24, 2025 07:19

Gang He added 3 commits November 27, 2025 11:14

drivers: dma: Fix DMA driver for SF32LB chipset

f942b8b

Add more callback in DMA processing, Fix DMA size bug. Signed-off-by: Gang He <[email protected]>

dts: Add audio codec device tree info for sf32lb52x

8c08ca5

Add audio codec device tree information for sf32lb52x.dtsi Signed-off-by: Gang He <[email protected]>

modules: hal_sifli: fix compile issue for SF32LB chipset

5428496

SF32LB52X audio HAL driver source code is not need in Zephyr driver. Signed-off-by: Gang He <[email protected]>

gangheivt force-pushed the codec branch from c7eb930 to 8691ddc Compare November 27, 2025 03:16

include: zephyr: audio: Update audio codec interface

28103f9

Support audio device that has both input and output function. Signed-off-by: Gang He <[email protected]>

gangheivt force-pushed the codec branch from 8691ddc to 091579c Compare November 28, 2025 02:56

ck-telecom requested changes Nov 28, 2025

View reviewed changes

JarmouniA previously requested changes Nov 28, 2025

View reviewed changes

ljq-ctrl and others added 2 commits November 29, 2025 09:28

drivers: audio: sf32lb52x: Add audio codec driver

7012aa6

audio playback and capure, extend API in codec.h Signed-off-by: ljq-ctrl <[email protected]>

board: sifli: sf32lb62_devkit_lcd: Add audio codec

7ddd08e

Add audio codec in board device tree, including PA control pin. Signed-off-by: Gang He <[email protected]>

gangheivt force-pushed the codec branch from 7b2ae6e to 2eaaa0e Compare November 29, 2025 01:30

samples: drivers: audio: Add codec loopback sample.

0112374

Add audio loop back sample Signed-off-by: ljq-ctrl <[email protected]>

ljq-ctrl force-pushed the codec branch from 2eaaa0e to 0112374 Compare November 29, 2025 04:45

JarmouniA reviewed Nov 29, 2025

View reviewed changes

		@@ -0,0 +1,22 @@
		# Copyright (c) 2025 Qingsong Gou <[email protected]>

	LOG_MODULE_REGISTER(siflicodec, CONFIG_AUDIO_CODEC_LOG_LEVEL);
	LOG_MODULE_REGISTER(sifli_codec, CONFIG_AUDIO_CODEC_LOG_LEVEL);


		static const struct device *codec_dev;

		static int config_dac_path(AUDCODEC_TypeDef *reg, uint16_t bypass)

	static struct sf32lb_audcodec_data data##n = { \
	}; \
	static struct sf32lb_audcodec_data data##n; \

drivers: audio: sf32lb52x: audio codec driver #98701

Are you sure you want to change the base?

drivers: audio: sf32lb52x: audio codec driver #98701

Uh oh!

Conversation

ljq-ctrl commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ljq-ctrl commented Nov 1, 2025

Uh oh!

Uh oh!

JarmouniA Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gmarull left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ljq-ctrl Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ljq-ctrl Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ljq-ctrl Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ljq-ctrl Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Nov 29, 2025

Quality Gate passed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

ljq-ctrl commented Nov 1, 2025 •

edited

Loading

JarmouniA Nov 1, 2025 •

edited

Loading

ljq-ctrl Nov 28, 2025 •

edited

Loading

ljq-ctrl Nov 28, 2025 •

edited

Loading

ljq-ctrl Nov 28, 2025 •

edited

Loading

ljq-ctrl Nov 28, 2025 •

edited

Loading