tests: kernel: pipe: Add concurrency test for zero-length pipes #98250
+48
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Kernel
area: Tests
zephyrbot
requested review from
TaiJuWu,
andyross,
ceolin,
cfriedt,
dcpleung,
nashif,
npitre and
peter-mitsis
npitre
previously approved these changes
Oct 26, 2025
peter-mitsis
requested changes
Oct 27, 2025
There was a problem hiding this comment.
I think this test needs a couple more checks to properly show the behavior described by the commit message.
- Since the claim is that the zero-length pipe should block, it is better to not rely upon just the pipe behavior. I recommend setting a global variable in both thread_read_write() and test_zero_size_pipe_read_write() so that it can be inspected and show that context switches did occur where they were expected.
- In test_zero_size_pipe_read_write(), I recommend initializing the contents of
outputso that they are guaranteed to be different than the initialized contents ofinput. Thus, when the two buffers are ultimately compared, we are that much more certain that the expected match is not a false positive from uninitialized data. - Similar to the previous comment, in thread_read_write(),
tmpshould be initialized to something different than bothinputandoutputfrom test_zero_size_pipe_read_write().
Mattemagikern
force-pushed
the
pipe_test
branch
from
de429b8 to
1607781
Compare
This commit adds a new test case to the pipe API concurrency tests to verify the behavior of zero-length pipes. The test ensures that writing to a zero-length pipe blocks until data is read, and reading from a zero-length pipe blocks until data is written—unless the pipe is closed, reset, or the operation times out. The test creates two pipes with zero-length buffers and spawns a helper thread that performs complementary read/write operations. The two threads use the pipe API as their only synchronization mechanism, validating the correct blocking and wake-up behavior of zero-length pipes under concurrent access. Signed-off-by: Måns Ansgariusson <[email protected]>
Mattemagikern
force-pushed
the
pipe_test
branch
from
1607781 to
133c49b
Compare
|
npitre
approved these changes
Oct 29, 2025
peter-mitsis
approved these changes
Oct 29, 2025
cfriedt
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new test case to the pipe API concurrency tests to verify the behavior of zero-length pipes. The test ensures that writing to a zero-length pipe blocks until data is read, and reading from a zero-length pipe blocks until data is written—unless the pipe is closed, reset, or the operation times out.
The test creates two pipes with zero-length buffers and spawns a helper thread that performs complementary read/write operations. The two threads use the pipe API as their only synchronization mechanism, validating the correct blocking and wake-up behavior of zero-length pipes under concurrent access.