Skip to content

Conversation

@gmarull
Copy link
Member

@gmarull gmarull commented Oct 21, 2025

Add board for Pebble 2 Duo. Most peripherals are supported, however,
some upstream changes are needed to take full benefit of some.

Depends on #97983

@gmarull gmarull requested a review from kartben October 21, 2025 19:58
@gmarull gmarull requested a review from carlescufi October 21, 2025 20:02
@gmarull gmarull force-pushed the p2d branch 3 times, most recently from 36bb696 to 655de10 Compare October 23, 2025 16:40
@gmarull gmarull marked this pull request as ready for review October 23, 2025 16:40
fabiobaltieri
fabiobaltieri previously approved these changes Oct 23, 2025
Copy link
Member

@fabiobaltieri fabiobaltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see double

@fabiobaltieri
Copy link
Member

It's like Core 2 duo.

@gmarull
Copy link
Member Author

gmarull commented Oct 24, 2025

It's like Core 2 duo.

it used to be called like this

@gmarull gmarull added this to the v4.3.0 milestone Oct 24, 2025
@kartben kartben requested a review from Copilot October 24, 2025 09:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds board support for the Pebble 2 Duo smartwatch, which is based on the Nordic nRF52840 SoC. The implementation provides configuration for most of the board's peripherals including sensors, display, audio, and connectivity features.

Key Changes:

  • Complete devicetree configuration for the Pebble 2 Duo hardware platform
  • Board-level configuration files for Zephyr RTOS integration
  • Documentation describing hardware features and programming interfaces

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
boards/coredevices/p2d/p2d.dts Main devicetree defining all peripheral configurations and pin assignments
boards/coredevices/p2d/p2d-pinctrl.dtsi Pin control definitions for all configured peripherals
boards/coredevices/p2d/p2d.yaml Board metadata including supported features and memory specifications
boards/coredevices/p2d/p2d_defconfig Default Kconfig settings enabling core features
boards/coredevices/p2d/board.cmake Programming/debugging tool configurations
boards/coredevices/p2d/board.yml Board registry information
boards/coredevices/p2d/Kconfig.p2d Kconfig file selecting the nRF52840 SoC
boards/coredevices/p2d/pre_dt_board.cmake Devicetree compiler flags configuration
boards/coredevices/p2d/doc/index.rst Hardware documentation and feature list

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Add board for Pebble 2 Duo. Most peripherals are supported, however,
some upstream changes are needed to take full benefit of some.

Signed-off-by: Gerard Marull-Paretas <[email protected]>
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants