Bluetooth: Fix double set random address for every advertising enable #97974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
HaavardRei,
PavelVPV,
Thalley,
alwa-nordic,
cvinayak,
hermabe,
jhedberg,
rugeGerritsen and
sjanc
LingaoM
force-pushed
the
fix_double_set_random_addr
branch
2 times, most recently
from
7790a4f to
a558bcf
Compare
zephyrbot
added
the
area: Tests
zephyrbot
requested review from
Andrewpini,
KyraLengfeld,
akredalen,
alxelax,
nashif and
omkar3141
LingaoM
force-pushed
the
fix_double_set_random_addr
branch
from
0e7b311 to
a558bcf
Compare
|
@PavelVPV I am confused about the failure of mesh relay in bbsim? |
LingaoM
force-pushed
the
fix_double_set_random_addr
branch
2 times, most recently
from
a04b899 to
8659046
Compare
LingaoM
force-pushed
the
fix_double_set_random_addr
branch
from
8659046 to
231ba67
Compare
The `bt_le_ext_adv_update_param` will set new random address when option not select `BT_LE_ADV_OPT_USE_IDENTITY`, But `bt_le_ext_adv_start` will also set random address again. This will be affect bluetooth mesh, after this change, will ensure address only change once for every advertising. Signed-off-by: Lingao Meng <[email protected]>
fix bluetooth mesh relay timing problem. Signed-off-by: Lingao Meng <[email protected]>
LingaoM
force-pushed
the
fix_double_set_random_addr
branch
2 times, most recently
from
38589d6 to
a7b7c06
Compare
|
@alxelax For Mesh bbsim problem, it's look like not problem, just timing changed. For PAST bbsim, even i revert these change, bbsim also not pass. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bt_le_ext_adv_update_paramwill set new random address when option not selectBT_LE_ADV_OPT_USE_IDENTITY, Butbt_le_ext_adv_startwill also set random address again.This will be affect bluetooth mesh, after this change, will ensure address only change once for every advertising.