manifest: optional: remove sof from optional manifest #97946
Conversation
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 removed project Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-sof
DNM (manifest)
nashif
force-pushed
the
topic/modules/optional_to_external_2
branch
from
d0b036b to
7ec8d06
Compare
Nothing in Zephyr uses zephyr, it is the other way round, SOF uses Zephyr, creating a cyclic dependency in some cases making it difficult to apply changes to areas used by SOF upstream. Part of zephyrproject-rtos#91061 Signed-off-by: Anas Nashif <[email protected]>
nashif
force-pushed
the
topic/modules/optional_to_external_2
branch
from
7ec8d06 to
d691906
Compare
|
@LaurentiuM1234 see https://github.com/zephyrproject-rtos/zephyr/actions/runs/18662605621/job/53206439186?pr=97946. You are checking for CONFIG_SOF in various places, this is not correct and is basically a layering violation. SOF is not part of Zephyr and we should not depend on it for hardware configuration. Can can you please take a look and see how you can get this working with check for SOF? |
|
@nashif wrote: I had no idea we had such a workaround. Any idea who added this comment? Git-blame gives me just the gigantic HWMv2 commit. It seems this is still depended on, builds will fail if I remove this. |
|
@kv2019i Is this something we can fix in SOF, ie. in with: diff --git a/src/arch/host/Kconfig b/src/arch/host/Kconfig
index de92f43a8..5ef3f7420 100644
--- a/src/arch/host/Kconfig
+++ b/src/arch/host/Kconfig
@@ -4,6 +4,6 @@
config CORE_COUNT
int
- default 1
+ default MP_MAX_NUM_CPUS
help
Number of used cores |
During transition to HWMv2 this workaround was added, which should instead be in SOF and not in Zephyr, as CORE_COUNT is a SOF Kconfig. Remove this and instead set the CORE_COUNT in SOF to the MP_MAX_NUM_CPUS. Signed-off-by: Anas Nashif <[email protected]>
rimage is used in the context of Sound Open Firmware (SOF) to sign the resulting firmware image. Since SOF is an external module, code found in mainline Zephyr should not depend on it, but, rather, the other way around. Therefore, drop the rimage signing support from the imx95_evk board. This should be handled in SOF instead of Zephyr. Needed for zephyrproject-rtos#91061. Signed-off-by: Laurentiu Mihalcea <[email protected]>
Remove SOF-specific region mappings. These should be handled inside of SOF (external module), instead of Zephyr. This way, we avoid creating a cyclic dependency between the two. Needed for zephyrproject-rtos#91061. Signed-off-by: Laurentiu Mihalcea <[email protected]>
zephyrbot
requested review from
JiafeiPan,
MaureenHelm,
Zhiqiang-Hou,
andyross,
ceolin,
dbaluta,
dcpleung,
dleach02,
iuliana-prodan,
stephanosio,
tmleman and
yangbolu1991
nashif
force-pushed
the
topic/modules/optional_to_external_2
branch
from
efe8831 to
9f338e3
Compare
|
see thesofproject/sof#10321 for changes needed on the SOF side |
Do not depend on SOF config, use RIMAGE_SCHEMA instead, defined in SOF. Signed-off-by: Anas Nashif <[email protected]>
nashif
force-pushed
the
topic/modules/optional_to_external_2
branch
from
9f338e3 to
44c214d
Compare
|
6 participants
Nothing in Zephyr uses SOF, it is the other way round, SOF uses
Zephyr, creating a cyclic dependency in some cases making it difficult
to apply changes to areas used by SOF upstream.
Part of #91061
Signed-off-by: Anas Nashif [email protected]