-
Notifications
You must be signed in to change notification settings - Fork 8.2k
boards: silabs: Support for efm32tg_stk3300 #91191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
boards: silabs: Support for efm32tg_stk3300 #91191
Conversation
fa107f3 to
8a321f6
Compare
|
Depends on PR for support for EFM32TG in hal_silabs. |
2a3ccfc to
fdb9a5f
Compare
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
split into multiple commits (at least 2) i.e. one for soc, one for board
| CONFIG_UART_CONSOLE=y | ||
| CONFIG_SERIAL=y | ||
| CONFIG_GPIO=y | ||
| CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC=32000000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get from dts property using function, and it should be set in soc Kconfig.defconfig file, not by a board
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the way other boards configure the clock cycles. It's also part of an example here: Board Porting Guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that documentation is very outdated and needs to be fixed, but this also needs to be fixed, this Kconfig needs to come from a dts value and in the soc Kconfig.defconfig file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather have this changed in a different PR. It should be consistent for all board. And then the documentation should be updated accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing new to be added with the old style, so if the old style remains in this PR then this PR will remain nacked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe @LukasWoodtli have already added the required changes in Kconfig.defconfig:
config SYS_CLOCK_HW_CYCLES_PER_SEC
default $(dt_node_int_prop_int,/cpus/cpu@0,clock-frequency)
He just forgot to remove the line above from efm32tg_stk3300_defconfig.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that's good. @LukasWoodtli could you do that last change then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LukasWoodtli I see you're pushing updates, but I don't see any change to this? As @jerome-pouiller wrote since you have the info correctly now in DTS it makes the above line redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it from efm32tg_stk3300_defconfig.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LukasWoodtli thanks. Unfortunately, this missed the Zephyr 4.3 feature freeze, which means that it would have to wait until the merge window opens again in some three weeks.
741d978 to
a24e5c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@LukasWoodtli is there a reason why you still want to keep this as a Draft PR? |
1b57b83 to
5baa9fd
Compare
|
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
5baa9fd to
3801999
Compare
1d3e602 to
ec67fdd
Compare
| @@ -0,0 +1,17 @@ | |||
| identifier: efm32tg_stk3300 | |||
| name: EFM32 Wonder Gecko Starter Kit (EFM32TG-STK3300, BRD2100) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder or Tiny?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Thanks
|
Do the TG and WG socs share characteristics? Can there be a shared dtsi between them? |
|
TG is one of the smallest Series 0 MCUs which a Cortex-M3 core, WG is one of the biggest with a Cortex-M4 core. While they have many of the same peripherals, the peripheral addresses etc are pretty different. So I don't think it makes sense to try sharing much. |
7aaedbb to
c864fce
Compare
c864fce to
9ee73e0
Compare
|
This PR needs a rebase. Since another PR that moves the hal_silabs module past the content needed in this PR has been merged, the changes to |
9ee73e0 to
4da1653
Compare
4da1653 to
9260939
Compare
|
@nordicjm could you take another look, since it seems your concerns should have been addressed. Not super urgent though, since this missed the feature freeze. |
* ARM Cortex-M3 processor * Up to 32 kB Flash and 4 kB RAM memory * Energy efficient and autonomous peripherals * Ultra low power Energy Modes * Fast wake-up Signed-off-by: Lukas Woodtli <[email protected]>
Support for the Silabs EFM32TG-STK3300 Starter Kit. Board features: * EFM32TG840F32 MCU with 32 kB flash and 4 kB RAM * Advanced Energy Monitoring * Real-time, accurate energy and power profiling * Light, LC and touch sensors * 8 x 20 LCD * SEGGER J-Link debugger Signed-off-by: Lukas Woodtli <[email protected]>
9260939 to
d720e99
Compare
|



Support for the Silabs EFM32TG-STK3300 Starter Kit.
Board features:
Signed-off-by: Lukas Woodtli [email protected]