Skip to content

Conversation

@LukasWoodtli
Copy link

@LukasWoodtli LukasWoodtli commented Jun 6, 2025

Support for the Silabs EFM32TG-STK3300 Starter Kit.

Board features:

  • EFM32TG840F32 MCU with 32 kB flash and 4 kB RAM
  • Advanced Energy Monitoring
  • Real-time, accurate energy and power profiling
  • Light, LC and touch sensors
  • 8 x 20 LCD
  • SEGGER J-Link debugger

Signed-off-by: Lukas Woodtli [email protected]

@LukasWoodtli
Copy link
Author

Depends on PR for support for EFM32TG in hal_silabs.

@github-actions
Copy link

github-actions bot commented Jun 6, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_silabs DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Jun 6, 2025
Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split into multiple commits (at least 2) i.e. one for soc, one for board

CONFIG_UART_CONSOLE=y
CONFIG_SERIAL=y
CONFIG_GPIO=y
CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC=32000000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get from dts property using function, and it should be set in soc Kconfig.defconfig file, not by a board

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the way other boards configure the clock cycles. It's also part of an example here: Board Porting Guide

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that documentation is very outdated and needs to be fixed, but this also needs to be fixed, this Kconfig needs to come from a dts value and in the soc Kconfig.defconfig file

Copy link
Author

@LukasWoodtli LukasWoodtli Jun 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather have this changed in a different PR. It should be consistent for all board. And then the documentation should be updated accordingly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing new to be added with the old style, so if the old style remains in this PR then this PR will remain nacked

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @LukasWoodtli have already added the required changes in Kconfig.defconfig:

config SYS_CLOCK_HW_CYCLES_PER_SEC
	default $(dt_node_int_prop_int,/cpus/cpu@0,clock-frequency)

He just forgot to remove the line above from efm32tg_stk3300_defconfig.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's good. @LukasWoodtli could you do that last change then?

Copy link
Member

@jhedberg jhedberg Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LukasWoodtli I see you're pushing updates, but I don't see any change to this? As @jerome-pouiller wrote since you have the info correctly now in DTS it makes the above line redundant.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it from efm32tg_stk3300_defconfig.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LukasWoodtli thanks. Unfortunately, this missed the Zephyr 4.3 feature freeze, which means that it would have to wait until the merge window opens again in some three weeks.

@LukasWoodtli LukasWoodtli force-pushed the efm32tg_stk3300 branch 2 times, most recently from 741d978 to a24e5c4 Compare June 10, 2025 20:09
Copy link
Contributor

@jerome-pouiller jerome-pouiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhedberg
Copy link
Member

@LukasWoodtli is there a reason why you still want to keep this as a Draft PR?

@sonarqubecloud
Copy link

@github-actions
Copy link

github-actions bot commented Sep 9, 2025

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Sep 9, 2025
@github-actions github-actions bot removed the Stale label Sep 19, 2025
@LukasWoodtli LukasWoodtli force-pushed the efm32tg_stk3300 branch 3 times, most recently from 1d3e602 to ec67fdd Compare October 13, 2025 19:36
@LukasWoodtli LukasWoodtli marked this pull request as ready for review October 13, 2025 20:13
@@ -0,0 +1,17 @@
identifier: efm32tg_stk3300
name: EFM32 Wonder Gecko Starter Kit (EFM32TG-STK3300, BRD2100)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder or Tiny?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks

@yishai1999
Copy link
Contributor

Do the TG and WG socs share characteristics? Can there be a shared dtsi between them?

@asmellby
Copy link
Contributor

TG is one of the smallest Series 0 MCUs which a Cortex-M3 core, WG is one of the biggest with a Cortex-M4 core. While they have many of the same peripherals, the peripheral addresses etc are pretty different. So I don't think it makes sense to try sharing much.

@asmellby
Copy link
Contributor

This PR needs a rebase. Since another PR that moves the hal_silabs module past the content needed in this PR has been merged, the changes to west.yml can be dropped from this PR.

@jhedberg
Copy link
Member

@nordicjm could you take another look, since it seems your concerns should have been addressed. Not super urgent though, since this missed the feature freeze.

@jhedberg jhedberg added this to the v4.4.0 milestone Oct 27, 2025
* ARM Cortex-M3 processor
* Up to 32 kB Flash and 4 kB RAM memory
* Energy efficient and autonomous peripherals
* Ultra low power Energy Modes
* Fast wake-up

Signed-off-by: Lukas Woodtli <[email protected]>
Support for the Silabs EFM32TG-STK3300 Starter Kit.

Board features:

* EFM32TG840F32 MCU with 32 kB flash and 4 kB RAM
* Advanced Energy Monitoring
* Real-time, accurate energy and power profiling
* Light, LC and touch sensors
* 8 x 20 LCD
* SEGGER J-Link debugger

Signed-off-by: Lukas Woodtli <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants