net: sockets: tls: Add new options for certificate verification #90068
+383
−142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new TLS socket option, TLS_CERT_VERIFY_RESULT, to obtain the certificate verification result from the most recent handshake on the socket. The option works if TLS_PEER_VERIFY_OPTIONAL was set on the socket, in which case the handshake may succeed even if certificate verification fails. Signed-off-by: Robert Lubos <[email protected]>
Extract server configuration, client configuration and test shutdown into separate functions so that they're reusable in other tests. Signed-off-by: Robert Lubos <[email protected]>
Add test case to verify if TLS_CERT_VERIFY_RESULT socket option works as expected. Signed-off-by: Robert Lubos <[email protected]>
Add new TLS socket option, TLS_CERT_VERIFY_CALLBACK, which allows to register an application callback to verify certificates obtained during the TLS handshake. Signed-off-by: Robert Lubos <[email protected]>
Add test case to verify if TLS_CERT_VERIFY_CALLBACK socket option works as expected. Signed-off-by: Robert Lubos <[email protected]>
rlubos
force-pushed
the
net/tls-cert-verify-opts
branch
from
fa5c83c to
fc6641d
Compare
|
jukkar
reviewed
May 16, 2025
| } | ||
|
|
||
| cert_verify = (struct tls_cert_verify_cb *)optval; | ||
| if (cert_verify->cb == NULL && cert_verify->ctx != NULL) { |
There was a problem hiding this comment.
Why do we care what the ctx is here, or was the idea that user can unset the callback by setting both values null (this is not documented if that is the idea)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new TLS socket options:
TLS_CERT_VERIFY_RESULTto retrieve certificate verification result,TLS_CERT_VERIFY_CALLBACKto regsiter ceritificate verification callback.Plus associated tests.
Resolves #52541