-
Notifications
You must be signed in to change notification settings - Fork 7.4k
CMSIS 6 update #90063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CMSIS 6 update #90063
Conversation
Add a note to announce the switch to CMSIS_6 for Cortex-M arch. Signed-off-by: Sudan Landge <[email protected]>
As noted in PR zephyrproject-rtos#89370, the content of these files falls below the trivial threshold. Therefore, it is not necessary to retain the original copyright, which was carried over when the files were copied from the `cmsis` module. Signed-off-by: Sudan Landge <[email protected]>
Zephyr switched to using CMSIS_6 module in f726cb5 which breaks certain boards like `nucleo_h745zi_q/stm32h745xx/m7` when CONFIG_CORTEX_M_DWT, CONFIG_TIMING_FUNCTIONS are enabled and cmsis from `module/hal/cmsis` is not available (deleted explicitly after west update). This commit adds a provision to be able to use CMSIS_6 macros when the module cmsis is not available. Signed-off-by: Sudan Landge <[email protected]>
|
@aescolar and @fabiobaltieri this PR is a follow up of the discussion in #89370, could you please have a look and let me know your thoughts? |
* As of commit f726cb5123eda12feb8746e3acb34a1f7d7b0340, Zephyr now uses the ``CMSIS_6`` module | ||
(instead of ``cmsis`` which was CMSIS 5.9.0) for Cortex-M architectures. | ||
Other modules still relying on the older ``cmsis`` module are encouraged to migrate to ``CMSIS_6``. | ||
The path to the ``CMSIS_6`` module can be accessed via the ``CONFIG_ZEPHYR_CMSIS_6_MODULE_DIR`` configuration. | ||
Note: Zephyr will continue using the older ``cmsis`` module for Cortex-A and Cortex-R targets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be moved to the migration guide. Release notes I say it should be more of a "new shiny features" document, I would not bother mentioning it here just on the migration guide. No need to mention the commit either, the document is the whole release. Wording sounds a bit funny, you are not exactly encouraged, it's more like you must migrate.
Keep it simple, straight to the point, something like: Cortex-M SoCs now require the cmsis_6 module to build properly. Basically the key information that should be there are for a user to understand:
- Am I affected (mention cortex-m)
- What should I do (have the module available)
Everything else (commit, the config thing, the path of the module...) aren't really helping.
Update release notes to announce the switch to CMSIS_6 for Cortex-M arch.
This also includes follow up changes discussed as part of PR #89370.