samples: Bluetooth: BAP: Unicast Server: Refactor TX #90052
Draft
+639
−143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the reporting interval configurable to make it easier to actually follow. Improve what gets reported. Add check for SDU size to ensure correctness when not using LIBLC3. Signed-off-by: Emil Gydesen <[email protected]>
Improve reporting by introducing a configurable reporting interval and make the report text more useful. Change TX to always send the same size, as that is what is expected/required by LE Audio. Signed-off-by: Emil Gydesen <[email protected]>
Refactors the TX of the unicast server. This commit effectively copies the TX approach of the unicast client sample, to make the sample more similar. This changes the TX to be based on the number of complete packets event (which results in free'ing the buffer), instead of a timer. This completely ensures that we do not skip any sequence numbers which may be rejected by the controller. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
unicast_server_tx_fix
branch
from
ddd8bc1 to
602d9d4
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the TX of the unicast server. This commit effectively
copies the TX approach of the unicast client sample, to make
the sample more similar.
This changes the TX to be based on the number of complete
packets event (which results in free'ing the buffer), instead of
a timer. This completely ensures that we do not skip any sequence
numbers which may be rejected by the controller.