Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindings: nxp,dai-sai: shorten property description and add configuration examples #85094

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 15 additions & 69 deletions dts/bindings/dai/nxp,dai-sai.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,100 +12,46 @@ properties:
required: true
mclk-is-output:
type: boolean
description: |
Use this property to set the SAI MCLK as output or as input.
By default, if this property is not specified, MCLK will be
set as input. Setting the MCLK as output for SAIs which don't
support MCLK configuration will result in a BUILD_ASSERT()
failure.
description: MCLK is configured as output.
rx-fifo-watermark:
type: int
description: |
Use this property to specify the watermark value for the TX
FIFO. This value needs to be in FIFO words (NOT BYTES). This
value needs to be in the following interval: (0, DEFAULT_FIFO_DEPTH],
otherwise a BUILD_ASSERT() failure will be raised.
description: Watermark value (in FIFO words) of RX FIFO.
tx-fifo-watermark:
type: int
description: |
Use this property to specify the watermark value for the RX
FIFO. This value needs to be in FIFO words (NOT BYTES). This
value needs to be in the following interval: (0, DEFAULT_FIFO_DEPTH],
otherwise a BUILD_ASSERT() failure will be raised.
description: Watermark value (in FIFO words) of TX FIFO.
interrupts:
required: true
fifo-depth:
type: int
description: |
Use this property to set the FIFO depth that will be reported
to other applications calling dai_get_properties(). This value
should be in the following interval: (0, DEFAULT_FIFO_DEPTH],
otherwise a BUILD_ASSERT() failure will be raised.
By DEFAULT_FIFO_DEPTH we mean the actual (hardware) value of
the FIFO depth. This is needed because some applications (e.g: SOF)
use this value to compute the DMA burst size, in which case
DEFAULT_FIFO_DEPTH cannot be used. Generally, reporting a false
FIFO depth should be avoided. Please note that the sanity check
for tx/rx-fifo-watermark uses DEFAULT_FIFO_DEPTH instead of this
value so use with caution. If unsure, it's better to simply not
use this property, in which case the reported value will be
DEFAULT_FIFO_DEPTH.
description: Size (in FIFO words) of the TX/RX FIFO.
Copy link
Collaborator

@mmahadevan108 mmahadevan108 Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find some of the description about how to pick the value (between 0 to DEFAULT_FIFO_DEPTH) useful to include here.

dai-index:
type: int
description: |
Use this property to specify the index of the DAI. At the
moment, this is only used by SOF to fetch the "struct device"
associated with the DAI whose index Linux passes to SOF
through an IPC. If this property is not specified, the DAI
index will be considered 0.
description: Index of the DAI instance. Must match Linux side.
tx-sync-mode:
type: int
enum:
- 0
- 1
description: |
Use this property to specify which synchronization mode to use
for the transmitter. At the moment, the only supported modes are:
1) The transmitter is ASYNC (0)
2) The transmitter is in SYNC with the receiver (1)
If this property is not specified, the transmitter will be set to ASYNC.
If one side is SYNC then the other MUST be ASYNC. Failing to meet this
condition will result in a failed BUILD_ASSERT().
Transmitter synchronization mode.

0: transmitter is ASYNC to receiver
1: transmitter is SYNC with receiver
rx-sync-mode:
type: int
enum:
- 0
- 1
description: |
Use this property to specify which synchronization mode to use
for the receiver. At the moment, the only supported modes are:
1) The receiver is ASYNC (0)
2) The receiver is in SYNC with the transmitter (1)
If this property is not specified, the receiver will be set to ASYNC.
If one side is SYNC then the other MUST be ASYNC. Failing to meet this
condition will result in a failed BUILD_ASSERT().
Receiver synchronization mode.

0: receiver is ASYNC to transmitter
1: receiver is SYNC with transmitter
tx-dataline:
type: int
description: |
Use this property to specify which transmission data line the SAI should
use. To find out which transmission line you should use you can:
1) Check the TRM and see if your SAI instance is multiline. If not then
you're going to use transmission line 0.
2) If your SAI is multiline then you need to check the datasheet and see
the index of the transmission line that's connected to your consumer
(e.g: the codec).
The indexing of the data line starts at 0. If this property is not specified
then the index of the transmission data line will be 0.
Please note that "channel" and "data line" are synnonyms in this context.
Index of the data line to transmit data on in multiline SAI instances.
rx-dataline:
type: int
description: |
Use this property to specify which receive transmission data line the SAI should
use. To find out which receive line you should use you can:
1) Check the TRM and see if your SAI instance is multiline. If not then
you're going to use receive line 0.
2) If your SAI is multiline then you need to check the datasheet and see
the index of the receive line that's connected to your consumer (e.g: the codec).
The indexing of the data line starts at 0. If this property is not specified
then the index of the receive data line will be 0.
Please note that "channel" and "data line" are synnonyms in this context.
Index of the data line to receive data on in multiline SAI instances.