Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nxp: imx8mp: support SDMA3 and SAI3 bus clock management #84972

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

nxp: imx8mp: support SDMA3 and SAI3 bus clock management #84972

wants to merge 5 commits into from
+146 −20

Conversation

LaurentiuM1234
Copy link
Collaborator

Add support for managing SAI3 and SDMA3 bus clocks. This means:

  1. Adding support for these clocks in clock_control_mcux_ccm.c
  2. Adding these clocks inside the DTS
  3. Adding support for PM runtime operations in SDMA driver.
  4. Adding support for multiple, different clock controllers in SAI driver.

@LaurentiuM1234
manifest: update hal_nxp
58e74d8 
Pull in the following patches:

devices: MIMX8ML8: fsl_clock: fix root clock gating/ungating
devices: MIMX8ML8: fsl_clock: change root clock ID for SAI3

Signed-off-by: Laurentiu Mihalcea <[email protected]>
@zephyrbot
Copy link
Collaborator

zephyrbot commented Jan 31, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@49ff7e3 (master) zephyrproject-rtos/hal_nxp#503 zephyrproject-rtos/hal_nxp#503/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Jan 31, 2025
@LaurentiuM1234 LaurentiuM1234 force-pushed the feat/imx8mp_sai3_sdma_clocks branch from 9f54866 to a519b44 Compare January 31, 2025 11:50
@LaurentiuM1234 LaurentiuM1234 marked this pull request as ready for review February 1, 2025 13:54
@zephyrbot zephyrbot added platform: NXP Drivers NXP Semiconductors, drivers area: DAI area: DMA Direct Memory Access area: Clock Control area: Xtensa Xtensa Architecture labels Feb 1, 2025
iuliana-prodan
iuliana-prodan previously approved these changes Feb 3, 2025
View reviewed changes
@fabiobaltieri fabiobaltieri added DNM (manifest) This PR should not be merged (controlled by action-manifest) and removed DNM This PR should not be merged (Do Not Merge) labels Feb 4, 2025
@LaurentiuM1234
drivers: dai: sai: support clocks from multiple providers
f8af332 
Current SAI code only supports clocks from a single provider. As such,
add support for having clocks from multiple, different providers.

Signed-off-by: Laurentiu Mihalcea <[email protected]>
@LaurentiuM1234
clock_control: mcux_ccm: add SAI and SDMA clocks
e69a7d4 
Add SAI1-3 and SDMA1-3 bus clocks for imx8mp.

Signed-off-by: Laurentiu Mihalcea <[email protected]>
@LaurentiuM1234
dts: xtensa: nxp_imx8m: add SAI3 and SDMA3 bus clocks
598e81e 
Add SAI3 and SDMA3 bus clocks.

Signed-off-by: Laurentiu Mihalcea <[email protected]>
@LaurentiuM1234
dma: dma_nxp_sdma: support pm runtime operations
11a4257 
Add support for PM runtime operations.

Signed-off-by: Laurentiu Mihalcea <[email protected]>
@LaurentiuM1234 LaurentiuM1234 force-pushed the feat/imx8mp_sai3_sdma_clocks branch from a519b44 to 11a4257 Compare February 5, 2025 17:35
@LaurentiuM1234
Copy link
Collaborator Author

V2 changes:

  • _SAI_GET_CLOCK_CONTROLLERS now returns { } instead of NULL if no clocks are specified. This is needed because of the cast to array type: "const struct device *[]".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbaluta dbaluta dbaluta approved these changes

@iuliana-prodan iuliana-prodan iuliana-prodan approved these changes

@andyross andyross Awaiting requested review from andyross

@dcpleung dcpleung Awaiting requested review from dcpleung

@decsny decsny Awaiting requested review from decsny

@dleach02 dleach02 Awaiting requested review from dleach02

@juimonen juimonen Awaiting requested review from juimonen

@kv2019i kv2019i Awaiting requested review from kv2019i

@lgirdwood lgirdwood Awaiting requested review from lgirdwood

@manuargue manuargue Awaiting requested review from manuargue

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@nashif nashif Awaiting requested review from nashif

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

@Raymond0225 Raymond0225 Awaiting requested review from Raymond0225

@teburd teburd Awaiting requested review from teburd

Assignees

@mmahadevan108 mmahadevan108

@dleach02 dleach02

Labels
area: Clock Control area: DAI area: DMA Direct Memory Access area: Xtensa Xtensa Architecture DNM (manifest) This PR should not be merged (controlled by action-manifest) manifest manifest-hal_nxp platform: NXP Drivers NXP Semiconductors, drivers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@LaurentiuM1234 @zephyrbot @dbaluta @iuliana-prodan @fabiobaltieri @mmahadevan108 @dleach02