Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial support for MICFIL PDM DAI #84881

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Add initial support for MICFIL PDM DAI #84881

merged 3 commits into from
Feb 7, 2025

Conversation

dbaluta
Copy link
Collaborator

@dbaluta dbaluta commented Jan 29, 2025

This adds initial support for PDM MICFIL DAI found on NXP i.MX8MP.

@dbaluta dbaluta self-assigned this Jan 29, 2025
@dbaluta dbaluta changed the title Add initial support for MICFIL PDM DAI [DNM] Add initial support for MICFIL PDM DAI Jan 29, 2025
@zephyrbot zephyrbot added area: DAI platform: NXP Drivers NXP Semiconductors, drivers area: Xtensa Xtensa Architecture labels Jan 29, 2025
@dbaluta dbaluta force-pushed the add_micfil branch 2 times, most recently from ebc085f to 4544bbf Compare February 3, 2025 16:46
@dbaluta dbaluta changed the title [DNM] Add initial support for MICFIL PDM DAI Add initial support for MICFIL PDM DAI Feb 3, 2025
@zephyrbot zephyrbot requested a review from Raymond0225 February 3, 2025 16:47
LaurentiuM1234
LaurentiuM1234 reviewed Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@LaurentiuM1234 LaurentiuM1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!. Some nitpicks/questions below

drivers/dai/nxp/micfil/micfil.c Outdated Show resolved Hide resolved
dts/bindings/dai/nxp,dai-micfil.yaml Show resolved Hide resolved
dts/xtensa/nxp/nxp_imx8m.dtsi Outdated Show resolved Hide resolved
drivers/dai/nxp/micfil/micfil.c Outdated Show resolved Hide resolved
drivers/dai/nxp/micfil/micfil.c Outdated Show resolved Hide resolved
drivers/dai/nxp/micfil/micfil.c Outdated Show resolved Hide resolved
drivers/dai/nxp/micfil/micfil.c Outdated Show resolved Hide resolved
drivers/dai/nxp/micfil/micfil.c Show resolved Hide resolved
drivers/dai/nxp/micfil/micfil.c Show resolved Hide resolved
drivers/dai/nxp/micfil/micfil.c Outdated Show resolved Hide resolved
@decsny decsny removed their request for review February 4, 2025 19:18
@dbaluta
Copy link
Collaborator Author

dbaluta commented Feb 5, 2025

-- Changes in v2, addressed comments from @LaurentiuM1234

@dbaluta
drivers: dai: Add new enum for PDM MICFIL type
087b41a 
Add new DAI type enum for PDM MICFIL.

Signed-off-by: Daniel Baluta <[email protected]>
LaurentiuM1234
LaurentiuM1234 reviewed Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@LaurentiuM1234 LaurentiuM1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more nits/questions below

drivers/dai/nxp/micfil/micfil.c Outdated Show resolved Hide resolved
drivers/dai/nxp/micfil/micfil.c Outdated Show resolved Hide resolved
drivers/dai/nxp/micfil/micfil.c Outdated Show resolved Hide resolved
@zephyrbot zephyrbot requested a review from JiafeiPan February 6, 2025 15:53
@dbaluta
Copy link
Collaborator Author

dbaluta commented Feb 6, 2025

-- Changes since v3

  • added support for configuring pinctrl from micfil zephyr driver, this will allow us to drop pinctrl from linux side.
  • dropped fifo_depth and used the one in rx_props
  • dropped function name
  • moved base to dai_nxp_micfil_config

@dbaluta
drivers: dai: Add initial support for NXP MICFIL PDM IP
3922963 
Introduce new DAI driver used for NXP's PDM MICFIL IP.
This block implements required digital interface to provide
a 24-bits audio signal from a PDM microphone bitstream in a configurable
output sampling rate.

Signed-off-by: Daniel Baluta <[email protected]>
@dbaluta
dts: xtensa: nxp_imx8m: Add PDM MICFIL node
56ccd97 
This adds micfil node for NPX i.MX8MP SOC.

Signed-off-by: Daniel Baluta <[email protected]>
LaurentiuM1234
LaurentiuM1234 approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@LaurentiuM1234 LaurentiuM1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work, thank you!

@kartben kartben merged commit aaa119d into zephyrproject-rtos:main Feb 7, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurentiuM1234 LaurentiuM1234 LaurentiuM1234 approved these changes

@dleach02 dleach02 dleach02 approved these changes

@iuliana-prodan iuliana-prodan Awaiting requested review from iuliana-prodan

@andyross andyross Awaiting requested review from andyross

@ceolin ceolin Awaiting requested review from ceolin

@dcpleung dcpleung Awaiting requested review from dcpleung

@juimonen juimonen Awaiting requested review from juimonen

@kv2019i kv2019i Awaiting requested review from kv2019i

@lgirdwood lgirdwood Awaiting requested review from lgirdwood

@manuargue manuargue Awaiting requested review from manuargue

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@nashif nashif Awaiting requested review from nashif

@Raymond0225 Raymond0225 Awaiting requested review from Raymond0225

@JiafeiPan JiafeiPan Awaiting requested review from JiafeiPan

Assignees

@dbaluta dbaluta

Labels
area: DAI area: Xtensa Xtensa Architecture platform: NXP Drivers NXP Semiconductors, drivers platform: NXP MPU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dbaluta @LaurentiuM1234 @dleach02 @kartben @zephyrbot