I2C support #99
Draft
I2C support #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make some small changes to try testing this on stm32. This change can be discarded. Signed-off-by: David Brown <[email protected]>
Upgrade the DT entries to use the new syntax. Signed-off-by: David Brown <[email protected]>
teburd
reviewed
May 23, 2025
|
|
||
| /// A single Sqe. | ||
| /// | ||
| /// TODO: How to bind the lifetime to the Rtio meaningfully, even though it is all static. |
There was a problem hiding this comment.
acquire can return sqe bound the lifetime of the context (which is true!)
| } | ||
|
|
||
| /// A single Cqe. | ||
| pub struct Cqe { |
There was a problem hiding this comment.
should take a lifetime parameter, bound to the lifetime of struct rtio
alternatively, you could use the copy in/copy out functions to avoid lifetimes at all
There was a problem hiding this comment.
I need to think about this a bit more, as the lifetimes of Rust structures are fairly uncorrelated with associated lifetimes in the C world. Specifically, the Rust lifetimes indicate constraints on what is allowed to happen in the Rust world.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This captures my current WIP i2c support.