manifest: stamp resolved/frozen manifests with the schema version#975
Open
pdgendt wants to merge 1 commit into
Open
manifest: stamp resolved/frozen manifests with the schema version#975pdgendt wants to merge 1 commit into
pdgendt wants to merge 1 commit into
Conversation
`west manifest --resolve` and `--freeze` dropped the `manifest: version:` key from their output. That output is a single manifest synthesized from the input and its imports -- which may each declare a different version -- so no single declared version describes it, and an older west would silently mis-parse newer content instead of failing with a clean ManifestVersionError. Stamp the output with SCHEMA_VERSION, the highest manifest schema version this west supports. That is a safe upper bound: west cannot emit anything newer than the schema it implements, and it covers imports that declare a newer version than the top-level manifest. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #975 +/- ##
=======================================
Coverage 86.35% 86.35%
=======================================
Files 11 11
Lines 3532 3533 +1
=======================================
+ Hits 3050 3051 +1
Misses 482 482
|
pdgendt
marked this pull request as ready for review
July 21, 2026 20:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
west manifest --resolveand--freezedropped themanifest: version:key from their output. That output is a single manifest synthesized from the input and its imports -- which may each declare a different version -- so no single declared version describes it, and an older west would silently mis-parse newer content instead of failing with a cleanManifestVersionError.Stamp the output with
SCHEMA_VERSION, the highest manifest schema version this west supports. That is a safe upper bound: west cannot emit anything newer than the schema it implements, and it covers imports that declare a newer version than the top-level manifest.