project: Ignore type checking in coverage #809
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running code coverage checks, ignore the special casing for TYPE_CHECKING Signed-off-by: Pieter De Gendt <[email protected]>
pdgendt
force-pushed
the
coverage-typecheck
branch
from
5fa48fa to
5be328a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #809 +/- ##
==========================================
- Coverage 85.18% 84.23% -0.95%
==========================================
Files 11 11
Lines 3334 3318 -16
==========================================
- Hits 2840 2795 -45
- Misses 494 523 +29 🚀 New features to boost your workflow:
|
|
I have no idea what this does, sorry. Would you have pointers to before/after logs/results? |
You can ignore this draft PR for now, is a test. |
I wish GitHub provided a way to exclude drafts (and only drafts) from notifications but last time I checked it was not possible :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running code coverage checks, ignore the special casing for TYPE_CHECKING