hal: esp32c6: Fix sleep routine #438
Open
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raffarost
requested review from
LucasTambor,
marekmatej,
sylvioalves and
wmrsouza
as code owners
raffarost
commented
May 8, 2025
sylvioalves
approved these changes
May 9, 2025
raffarost
force-pushed
the
fix/esp32c6/sleep
branch
from
ba19475 to
bf6f6ac
Compare
wmrsouza
reviewed
May 9, 2025
raffarost
force-pushed
the
fix/esp32c6/sleep
branch
from
bf6f6ac to
6f8fbb5
Compare
LucasTambor
requested changes
May 9, 2025
There was a problem hiding this comment.
You are reverting some changes that were not added by #335 but that are needed for esp32c6's LP Core support. Did you tested this with LP Core build?
There was a problem hiding this comment.
Thanks for pointing it out. I checked IDF's individual changes and probably doing the minimal changes is a better option.
Fix sleep routine for ESP32-C6 after regression when updating HAL to v.5.1.c. Signed-off-by: Raffael Rostagno <[email protected]>
raffarost
force-pushed
the
fix/esp32c6/sleep
branch
from
6f8fbb5 to
a03cbeb
Compare
sylvioalves
approved these changes
May 20, 2025
wmrsouza
approved these changes
May 20, 2025
sylvioalves
approved these changes
May 28, 2025
marekmatej
approved these changes
May 28, 2025
LucasTambor
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix sleep routine for ESP32-C6 after regression when updating HAL to v.5.1.c (PR #335).