fix: pin pygobject pip package to 3.50.0 #223
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions of pygobject from 3.51.0 forward require libgirepository-2.0-dev as a dependency, but that one is not yet available on the Ubuntu 22.04 (it is on 24.04). 3.50.0 version requires libgirepository-1.0-dev, which is available on the Ubuntu 22.04, however that package was never explicitly installed, so this commit also adds it. By pinning the pip package and adding new apt package we ensure that Dockerfile.base can be even built. Closes: zephyrproject-rtos#222
stephanosio
reviewed
Apr 11, 2025
|
Hi, sorry for the late response. You are right, the base image builds successfully, but I remember that I tried to build it, before opening the linked issue and this PR. I have built the image locally and checked the version of the installed pygobject package, it is Maybe pip decided that this version of the pygoobject is compatible with all other versions and that's why it doesn't try to install more recent one? Anyway, I guess that this PR (and issue) can be closed, please do so if you see fit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions of pygobject from 3.51.0 forward require
libgirepository-2.0-dev as a dependency, but that one is not yet available on the Ubuntu 22.04 (it is on 24.04).
3.50.0 version requires libgirepository-1.0-dev, which is available on the Ubuntu 22.04, however that package was never explicitly installed, so this commit also adds it.
By pinning the pip package and adding new apt package we ensure that Dockerfile.base can be even built.
Closes: #222