Update deployment server main page #4068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
ZenML CLI Performance Comparison (Threshold: 1.0s, Timeout: 60s, Slow: 5s)❌ Failed Commands on Current Branch (feature/update-deployment-server-main-page)
🚨 New Failures IntroducedThe following commands fail on your branch but worked on the target branch:
Performance Comparison
Summary
Environment Info
|
There was a problem hiding this comment.
- I couldnt find a
formelement. Maybe we should use that in combination with<button type="submit">, to get the "keyboard-enter" submission with html native elements
I haven't tested functionality yet, these are just my first findings going through the huge file
| const field = document.createElement('div'); | ||
| field.className = 'output-field'; | ||
| field.innerHTML = ` | ||
| <div class="output-field-key">${key}</div> |
There was a problem hiding this comment.
The inner html is set without sanitization.
If the endponit for some reason returns malicious html, this is straight injected here. e.g
<img src=x onerror=alert('XSS from pipeline output')>
| }); | ||
|
|
||
| document.getElementById('rerun-btn').addEventListener('click', runPipeline); | ||
| document.getElementById('delete-btn').addEventListener('click', () => { |
There was a problem hiding this comment.
Does the delete-btn actually perform a deletion?
There was a problem hiding this comment.
it clears the output
stefannica
reviewed
Oct 24, 2025
…loyment-server-main-page
|
Those .svg assets are not used anywhere, are they ? |
Documentation Link Check Results❌ Absolute links check failed |
stefannica
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe changes
I implemented/fixed _ to achieve _.
Pre-requisites
Please ensure you have done the following:
developand the open PR is targetingdevelop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes