This repository was archived by the owner on Nov 23, 2024. It is now read-only.

Use json_encode() to encode options #24

Open

thomasbachem wants to merge 3 commits into zendesk:master from thomasbachem:json-encode

thomasbachem commented Jul 25, 2017

This has several advantages:

We don't need the decodeEntities() JS function
It's the safest way to encode JS stuff
User data like names and email are only included when not empty

thomasbachem added 3 commits

July 25, 2017 12:34


          Use json_encode() instead of htmlentities()

5dff0cd


          Build whole options object with json_encode()

b092a29


          Fixed JS syntax

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet