Merge pull request #23 from zenangst/fix/crash-reloading-without-a-su…

…perview

Add safe-guard for reloading without a superview

Differific.podspec

@@ -1,7 +1,7 @@
 Pod::Spec.new do |s|
   s.name             = "Differific"
   s.summary          = "A fast and convenient diffing framework"
-  s.version          = "0.8.2"
+  s.version          = "0.8.3"
   s.homepage         = "https://github.com/zenangst/Differific"
   s.license          = 'MIT'
   s.author           = { "Christoffer Winterkvist" => "[email protected]" }

Source/iOS+tvOS/UICollectionView+Extensions.swift

@@ -18,6 +18,13 @@ extension UICollectionView {
       return
     }
 
+    if superview == nil {
+      updateDataSource()
+      reloadData()
+      completion?()
+      return
+    }
+
     setNeedsLayout()
     layoutIfNeeded()
 

Source/iOS+tvOS/UITableView+Extensions.swift

@@ -20,6 +20,13 @@ public extension UITableView {
       return
     }
 
+    if superview == nil {
+      updateDataSource()
+      reloadData()
+      completion?()
+      return
+    }
+
     setNeedsLayout()
     layoutIfNeeded()
 

Source/macOS/NSCollectionView+Extensions.swift

@@ -19,6 +19,13 @@ public extension NSCollectionView {
       return
     }
 
+    if superview == nil {
+      updateDataSource()
+      reloadData()
+      completion?()
+      return
+    }
+
     let manager = IndexPathManager()
     let result = manager.process(changes, section: section)
     let object = animations ? animator() : self

Source/macOS/NSTableView+Extensions.swift

@@ -19,6 +19,13 @@ public extension NSTableView {
       completion?()
       return
     }
+
+    if superview == nil {
+      updateDataSource()
+      reloadData()
+      completion?()
+      return
+    }
 
     let manager = IndexPathManager()
     let result = manager.process(changes, section: section)

Tests/macOS/NSCollectionViewExtensionTests.swift

@@ -50,7 +50,9 @@ class NSCollectionViewExtensionsTests: XCTestCase {
     let dataSource = DataSourceMock(models: ["Foo", "Bar", "Baz"])
     let layout = NSCollectionViewFlowLayout()
     layout.itemSize = CGSize(width: 250, height: 250)
+    let superview = NSView()
     let collectionView = NSCollectionView(frame: .init(origin: .zero, size: layout.itemSize))
+    superview.addSubview(collectionView)
     collectionView.collectionViewLayout = layout
     collectionView.dataSource = dataSource
     collectionView.register(NSCollectionViewItem.self, forItemWithIdentifier: NSUserInterfaceItemIdentifier.init("cell"))
@@ -78,7 +80,9 @@ class NSCollectionViewExtensionsTests: XCTestCase {
     let dataSource = DataSourceMock(models: ["Foo", "Bar", "Baz"])
     let layout = NSCollectionViewFlowLayout()
     layout.itemSize = CGSize(width: 250, height: 250)
+    let superview = NSView()
     let collectionView = NSCollectionView(frame: .init(origin: .zero, size: layout.itemSize))
+    superview.addSubview(collectionView)
     collectionView.collectionViewLayout = layout
     collectionView.dataSource = dataSource
     collectionView.register(NSCollectionViewItem.self, forItemWithIdentifier: NSUserInterfaceItemIdentifier.init("cell"))